From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNS9w-0001ZS-3j for qemu-devel@nongnu.org; Fri, 20 May 2011 12:02:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QNS9u-00034n-LG for qemu-devel@nongnu.org; Fri, 20 May 2011 12:02:39 -0400 Received: from goliath.siemens.de ([192.35.17.28]:31090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNS9u-00034i-8h for qemu-devel@nongnu.org; Fri, 20 May 2011 12:02:38 -0400 Message-ID: <4DD6909A.5040906@siemens.com> Date: Fri, 20 May 2011 18:02:34 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4DD2AAE5.1020408@siemens.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] net: Dump client type 'info network' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel On 2011-05-18 10:09, Markus Armbruster wrote: > Jan Kiszka writes: > >> Include the client type name into the output of 'info network'. The >> result looks like this: >> >> (qemu) info network >> VLAN 0 devices: >> rtl8139.0 (NIC): model=rtl8139,macaddr=52:54:00:12:34:57 >> Devices not on any VLAN: >> virtio-net-pci.0 (NIC): model=virtio-net-pci,macaddr=52:54:00:12:34:56 >> \ network1 (tap): fd=5 > > I guess I'd prefix vc->infostr with type=WHATEVER, for consistency with > the command line, like this: > > (qemu) info network > VLAN 0 devices: > rtl8139.0: type=nic,model=rtl8139,macaddr=52:54:00:12:34:57 > Devices not on any VLAN: > virtio-net-pci.0: type=nic,model=virtio-net-pci,macaddr=52:54:00:12:34:56 > \ network1: type=tap,fd=5 That really only creates consistency for the 'user' client. Other clients put arbitrarily formatted strings into info_str. If it's still preferred that way, no big deal, just wanted to point it out. > >> >> Signed-off-by: Jan Kiszka >> --- >> net.c | 18 +++++++++++++++--- >> 1 files changed, 15 insertions(+), 3 deletions(-) >> >> diff --git a/net.c b/net.c >> index 606ce70..a4ee6b1 100644 >> --- a/net.c >> +++ b/net.c >> @@ -1223,6 +1223,15 @@ int do_netdev_del(Monitor *mon, const QDict *qdict, QObject **ret_data) >> >> void do_info_network(Monitor *mon) >> { >> + static const char *typename[] = { >> + [NET_CLIENT_TYPE_NONE] = "none", >> + [NET_CLIENT_TYPE_NIC] = "NIC", >> + [NET_CLIENT_TYPE_SLIRP] = "user IPv4", >> + [NET_CLIENT_TYPE_TAP] = "tap", >> + [NET_CLIENT_TYPE_SOCKET] = "socket", >> + [NET_CLIENT_TYPE_VDE] = "VDE", >> + [NET_CLIENT_TYPE_DUMP] = "dump", >> + }; > > Why not use the type names from net_client_types[]? Easier, and > consistent with the command line. Will do. Thanks, Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux