From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47562)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1QNSJ5-0006xE-VZ
	for qemu-devel@nongnu.org; Fri, 20 May 2011 12:12:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1QNSJ5-0004Yd-1p
	for qemu-devel@nongnu.org; Fri, 20 May 2011 12:12:07 -0400
Received: from david.siemens.de ([192.35.17.14]:33248)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1QNSJ4-0004YY-Nj
	for qemu-devel@nongnu.org; Fri, 20 May 2011 12:12:07 -0400
Message-ID: <4DD692D5.4000706@siemens.com>
Date: Fri, 20 May 2011 18:12:05 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <4DD2AAE5.1020408@siemens.com>
	<m3vcx8fn0f.fsf@blackfin.pond.sub.org>
	<4DD6909A.5040906@siemens.com>
In-Reply-To: <4DD6909A.5040906@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] net: Dump client type 'info network'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 2011-05-20 18:02, Jan Kiszka wrote:
> On 2011-05-18 10:09, Markus Armbruster wrote:
>> Jan Kiszka <jan.kiszka@siemens.com> writes:
>>
>>> Include the client type name into the output of 'info network'. The
>>> result looks like this:
>>>
>>> (qemu) info network
>>> VLAN 0 devices:
>>>   rtl8139.0 (NIC): model=rtl8139,macaddr=52:54:00:12:34:57
>>> Devices not on any VLAN:
>>>   virtio-net-pci.0 (NIC): model=virtio-net-pci,macaddr=52:54:00:12:34:56
>>>    \ network1 (tap): fd=5
>>
>> I guess I'd prefix vc->infostr with type=WHATEVER, for consistency with
>> the command line, like this:
>>
>>   (qemu) info network
>>   VLAN 0 devices:
>>     rtl8139.0: type=nic,model=rtl8139,macaddr=52:54:00:12:34:57
>>   Devices not on any VLAN:
>>     virtio-net-pci.0: type=nic,model=virtio-net-pci,macaddr=52:54:00:12:34:56
>>      \ network1: type=tap,fd=5
> 
> That really only creates consistency for the 'user' client. Other
> clients put arbitrarily formatted strings into info_str. If it's still
> preferred that way, no big deal, just wanted to point it out.

Umm, obviously nic and tap are formatting similar, just dump and
(broken-again-by-someone) socket do not. So let's go for type=.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux