From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] softfloat: extract softfloat-target.h
Date: Fri, 20 May 2011 21:45:09 +0200 [thread overview]
Message-ID: <4DD6C4C5.7060909@redhat.com> (raw)
In-Reply-To: <BANLkTimVTyr0YxmcoQ9souCM5eEg0etONw@mail.gmail.com>
On 05/20/2011 09:38 PM, Blue Swirl wrote:
> On Thu, May 19, 2011 at 4:47 PM, Paolo Bonzini<pbonzini@redhat.com> wrote:
> > Most definitions in softfloat.h are really target-independent. Split
> > the few that stand out as target-dependent, to allow including
> > softfloat.h from files that are not compiled per-target.
>
> Maybe the next step should be (or in place of this patch) to move the
> various defines to target-xyz/cpu.h?
Not sure... Adding (or increasing, I haven't checked) the dependency of
softfloat on */cpu.h is bad, but a new file
target-xyz/softfloat-target.h would be feasible. You'd miss the
classification in the two big groups (sNAN sign bit = 0/1), but that's
not a big deal.
Regarding "in place of this patch" however I disagree, since this patch
is a naive split of a file in two big pieces, while your proposal
requires more thought.
Paolo
next prev parent reply other threads:[~2011-05-20 19:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 13:46 [Qemu-devel] [PATCH 0/3] make endian-independent unaligned memory access functions available in libhw Paolo Bonzini
2011-05-19 13:46 ` [Qemu-devel] [PATCH 1/3] move WORDS_ALIGNED to qemu-common.h Paolo Bonzini
2011-05-19 13:47 ` [Qemu-devel] [PATCH 2/3] softfloat: extract softfloat-target.h Paolo Bonzini
2011-05-20 19:38 ` Blue Swirl
2011-05-20 19:45 ` Paolo Bonzini [this message]
2011-05-20 19:54 ` Blue Swirl
2011-05-23 21:11 ` Aurelien Jarno
2011-05-24 6:37 ` Paolo Bonzini
2011-05-19 13:47 ` [Qemu-devel] [PATCH 3/3] move unaligned memory access functions to bswap.h Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD6C4C5.7060909@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.