All of lore.kernel.org
 help / color / mirror / Atom feed
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] drivers/amba: probe via device tree
Date: Sat, 21 May 2011 09:55:09 -0500	[thread overview]
Message-ID: <4DD7D24D.2070604@gmail.com> (raw)
In-Reply-To: <80f20ac921a33e9f0bf3e249f539a8ef@kernel.crashing.org>

On 05/20/2011 11:00 PM, Segher Boessenkool wrote:
>> The ARM definition of AMBA encompasses a lot of things. It is the
>> definition of the AXI, AHB and APB buses.
>
> So the device tree, which describes the hardware, should call the buses
> axi, ahb or apb as appropriate, and describe the actual physical
> connections.
> The Linux kernel is free to ignore that if it so wishes.
>
>> It also has the definition of the peripheral ID register definitions
>> which primarily only ARM Ltd peripherals implement. You can have those
>> bus types yet not have any peripherals with the ID registers.
>
> The devices are identified in the device tree, you do not need to read
> the ID registers to find them. You should have some way of figuring out
> which devices have the AMBA ID block; maybe add something to the
> "compatible"
> property and have all devices that use this have this register block as the
> first entry in the "reg" property?
>

Identifying actual AMBA devices is already done. The question is how to 
scan the tree for them and how that relates to regular platform devices. 
The AMBA devices have a binding like this:

compatible = "arm,pl011", "arm,amba-device";
arm,amba-deviceid = <0x00341011>;

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Segher Boessenkool
	<segher-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	Jeremy Kerr <jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/2] drivers/amba: probe via device tree
Date: Sat, 21 May 2011 09:55:09 -0500	[thread overview]
Message-ID: <4DD7D24D.2070604@gmail.com> (raw)
In-Reply-To: <80f20ac921a33e9f0bf3e249f539a8ef-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>

On 05/20/2011 11:00 PM, Segher Boessenkool wrote:
>> The ARM definition of AMBA encompasses a lot of things. It is the
>> definition of the AXI, AHB and APB buses.
>
> So the device tree, which describes the hardware, should call the buses
> axi, ahb or apb as appropriate, and describe the actual physical
> connections.
> The Linux kernel is free to ignore that if it so wishes.
>
>> It also has the definition of the peripheral ID register definitions
>> which primarily only ARM Ltd peripherals implement. You can have those
>> bus types yet not have any peripherals with the ID registers.
>
> The devices are identified in the device tree, you do not need to read
> the ID registers to find them. You should have some way of figuring out
> which devices have the AMBA ID block; maybe add something to the
> "compatible"
> property and have all devices that use this have this register block as the
> first entry in the "reg" property?
>

Identifying actual AMBA devices is already done. The question is how to 
scan the tree for them and how that relates to regular platform devices. 
The AMBA devices have a binding like this:

compatible = "arm,pl011", "arm,amba-device";
arm,amba-deviceid = <0x00341011>;

Rob

  reply	other threads:[~2011-05-21 14:55 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19 18:28 [PATCH v2 0/2] amba bus device tree probing Rob Herring
2011-05-19 18:28 ` Rob Herring
2011-05-19 18:28 ` [PATCH 1/2] dt: check for devices already created fron DT scan Rob Herring
2011-05-19 18:28   ` Rob Herring
2011-05-19 19:54   ` Grant Likely
2011-05-19 19:54     ` Grant Likely
2011-05-19 18:28 ` [PATCH 2/2] drivers/amba: probe via device tree Rob Herring
2011-05-19 18:28   ` Rob Herring
2011-05-19 20:01   ` Grant Likely
2011-05-19 20:01     ` Grant Likely
2011-05-19 23:30     ` Rob Herring
2011-05-19 23:30       ` Rob Herring
2011-05-19 23:39       ` Grant Likely
2011-05-19 23:39         ` Grant Likely
2011-05-20 13:24         ` Rob Herring
2011-05-20 13:24           ` Rob Herring
2011-05-20 14:21           ` Arnd Bergmann
2011-05-20 14:21             ` Arnd Bergmann
2011-05-20 15:17             ` Rob Herring
2011-05-20 15:17               ` Rob Herring
2011-05-20 16:08               ` Stephen Neuendorffer
2011-05-20 16:08                 ` Stephen Neuendorffer
2011-05-21 17:42                 ` Grant Likely
2011-05-21 17:42                   ` Grant Likely
2011-05-21 23:47                   ` Russell King - ARM Linux
2011-05-21 23:47                     ` Russell King - ARM Linux
2011-05-21 23:47                     ` Russell King - ARM Linux
2011-05-22 10:00                     ` Rafael J. Wysocki
2011-05-22 10:00                       ` Rafael J. Wysocki
2011-05-22 10:00                       ` Rafael J. Wysocki
2011-05-22 15:46                     ` Rob Herring
2011-05-22 15:46                       ` Rob Herring
2011-05-22 15:46                       ` Rob Herring
2011-05-23 15:23                     ` Grant Likely
2011-05-23 15:23                       ` Grant Likely
2011-05-22 10:03                   ` Arnd Bergmann
2011-05-22 10:03                     ` Arnd Bergmann
2011-05-22 10:03                     ` Arnd Bergmann
2011-05-25  9:03                     ` Linus Walleij
2011-05-25  9:03                       ` Linus Walleij
2011-05-23  9:37                   ` Kristoffer Glembo
2011-05-23  9:37                     ` Kristoffer Glembo
2011-05-23  9:37                     ` Kristoffer Glembo
2011-05-23  9:58                     ` Russell King - ARM Linux
2011-05-23  9:58                       ` Russell King - ARM Linux
2011-05-23 15:09                       ` Grant Likely
2011-05-23 15:09                         ` Grant Likely
2011-05-23 15:09                         ` Grant Likely
2011-05-24 15:03                         ` Rob Herring
2011-05-24 15:03                           ` Rob Herring
2011-05-24 15:03                           ` Rob Herring
2011-05-25  3:02                           ` Shawn Guo
2011-05-25  3:02                             ` Shawn Guo
2011-05-25  3:02                             ` Shawn Guo
2011-05-25  9:07                           ` Linus Walleij
2011-05-25  9:07                             ` Linus Walleij
2011-05-21 23:35                 ` Russell King - ARM Linux
2011-05-21 23:35                   ` Russell King - ARM Linux
2011-05-23 15:00                   ` Stephen Neuendorffer
2011-05-23 15:00                     ` Stephen Neuendorffer
2011-05-23 15:47                     ` Russell King - ARM Linux
2011-05-23 15:47                       ` Russell King - ARM Linux
2011-05-21  4:00               ` Segher Boessenkool
2011-05-21  4:00                 ` Segher Boessenkool
2011-05-21 14:55                 ` Rob Herring [this message]
2011-05-21 14:55                   ` Rob Herring
2011-05-21 15:18                   ` Segher Boessenkool
2011-05-21 15:18                     ` Segher Boessenkool
2011-05-21 17:43                     ` Grant Likely
2011-05-21 17:43                       ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DD7D24D.2070604@gmail.com \
    --to=robherring2@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.