From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86 emulator: Fix unconditional return from get_descriptor_table_ptr() Date: Sun, 22 May 2011 15:57:10 +0300 Message-ID: <4DD90826.9040806@redhat.com> References: <20110521130639.d4615ee1.takuya.yoshikawa@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:6890 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754760Ab1EVM5S (ORCPT ); Sun, 22 May 2011 08:57:18 -0400 In-Reply-To: <20110521130639.d4615ee1.takuya.yoshikawa@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/21/2011 07:06 AM, Takuya Yoshikawa wrote: > From: Takuya Yoshikawa > > A trivial typo was found in the following commit: > commit 7753ed6043bfce55dc0c407490896632014b677e > KVM: x86 emulator: drop vcpu argument from segment/gdt/idt callbacks > > When the table indicator flag is set, when the selector selects the > current LDT, get_descriptor_table_ptr() returns without setting the > size and address of the table. > > Guests will see #GP if this happens. > Thanks, applied. > Signed-off-by: Takuya Yoshikawa > --- > Is this stable material? -- IIRC, someone reported a suspicous > emulator bug recently. This was not yet merged upstream, so I folded this into the bad commit, and upstream will never see the bug. It's now 4bff1e86ad286d in kvm.git. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.