From: Christoph Egger <Christoph.Egger@amd.com>
To: Keir Fraser <keir.xen@gmail.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] xen: cleanup headers
Date: Mon, 23 May 2011 11:17:11 +0200 [thread overview]
Message-ID: <4DDA2617.7060708@amd.com> (raw)
In-Reply-To: <C9FC38DC.1AA4B%keir.xen@gmail.com>
On 05/20/11 16:27, Keir Fraser wrote:
> On 20/05/2011 13:58, "Christoph Egger"<Christoph.Egger@amd.com> wrote:
>
>>
>> Include headers that are actually needed, drop everything else.
>
>> Do not use BUG() in public headers.
>
> Why would that be a problem in an ifdef-__XEN__ region?
>
> -- Keir
Why is an ifdef-__XEN__ region needed at all in a public header ?
Christoph
>> Signed-off-by: Christoph Egger<Christoph.Egger@amd.com>
>
>
>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
prev parent reply other threads:[~2011-05-23 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 12:58 [PATCH] xen: cleanup headers Christoph Egger
2011-05-20 14:27 ` Keir Fraser
2011-05-23 9:17 ` Christoph Egger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDA2617.7060708@amd.com \
--to=christoph.egger@amd.com \
--cc=keir.xen@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.