From: Randy Dunlap <randy.dunlap@oracle.com>
To: Mike Waychison <mikew@google.com>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>, gregkh <greg@kroah.com>
Subject: Re: [PATCH -next] firmware: fix GOOGLE_SMI kconfig dependency warning
Date: Mon, 23 May 2011 08:15:48 -0700 [thread overview]
Message-ID: <4DDA7A24.6050909@oracle.com> (raw)
In-Reply-To: <BANLkTi=T4JsDZ7EX18AHcwG8nd50FzHGtg@mail.gmail.com>
On 05/22/11 22:39, Mike Waychison wrote:
>
> On May 22, 2011 5:38 PM, "Randy Dunlap" <randy.dunlap@oracle.com
> <mailto:randy.dunlap@oracle.com>> wrote:
>>
>> From: Randy Dunlap <randy.dunlap@oracle.com
> <mailto:randy.dunlap@oracle.com>>
>>
>> Is it meaningful/useful to enable EFI_VARS but not EFI?
>> That's what GOOGLE_SMI does. Make it enable EFI also.
>>
>> Fixes this kconfig dependency warning:
>>
>> warning: (GOOGLE_SMI) selects EFI_VARS which has unmet direct
> dependencies (EFI)
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com
> <mailto:randy.dunlap@oracle.com>>
>> Cc: Mike Waychison <mikew@google.com <mailto:mikew@google.com>>
>
> Acked.
>
> Is this a new warning? I haven't seen it before which is weird because
> we don't use efi boot.
It's not new for 20110520, but I don't know when it began.
>> ---
>> drivers/firmware/google/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20110520.orig/drivers/firmware/google/Kconfig
>> +++ linux-next-20110520/drivers/firmware/google/Kconfig
>> @@ -13,6 +13,7 @@ menu "Google Firmware Drivers"
>> config GOOGLE_SMI
>> tristate "SMI interface for Google platforms"
>> depends on ACPI && DMI
>> + select EFI
>> select EFI_VARS
>> help
>> Say Y here if you want to enable SMI callbacks for Google
>
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
prev parent reply other threads:[~2011-05-23 15:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 6:55 linux-next: Tree for May 20 Stephen Rothwell
2011-05-20 17:54 ` linux-next: Tree for May 20 (iwlwifi) Randy Dunlap
2011-05-20 18:35 ` wwguy
2011-05-23 0:32 ` [PATCH -next] ata: PATA_ARASAN_CF depends on DMADEVICES Randy Dunlap
2011-05-23 3:35 ` viresh kumar
2011-05-23 16:21 ` Randy Dunlap
2011-05-24 3:38 ` viresh kumar
2011-05-23 0:34 ` [PATCH -next] media: fix kconfig dependency warning for VIDEO_TIMBERDALE Randy Dunlap
2011-05-23 0:38 ` [PATCH -next] firmware: fix GOOGLE_SMI kconfig dependency warning Randy Dunlap
[not found] ` <BANLkTi=T4JsDZ7EX18AHcwG8nd50FzHGtg@mail.gmail.com>
2011-05-23 15:15 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDA7A24.6050909@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mikew@google.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.