From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Hans Petter Selasky <hselasky@c2i.net>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH] Inlined functions should be static.
Date: Mon, 23 May 2011 15:29:28 -0300 [thread overview]
Message-ID: <4DDAA788.80908@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1105232022460.30305@axis700.grange>
Em 23-05-2011 15:23, Guennadi Liakhovetski escreveu:
> On Mon, 23 May 2011, Hans Petter Selasky wrote:
>
>> --HPS
>>
>
> (again, inlining would save me copy-pasting)
Yeah... hard to comment not-inlined patches...
>
>> -inline u32 stb0899_do_div(u64 n, u32 d)
>> +static inline u32 stb0899_do_div(u64 n, u32 d)
>
> while at it you could as well remove the unneeded in a C file "inline"
> attribute.
hmm... foo_do_div()... it seems to be yet-another-implementation
of asm/div64.h. If so, it is better to just remove this thing
and use the existing function.
>
> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
next prev parent reply other threads:[~2011-05-23 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 14:07 [PATCH] Inlined functions should be static Hans Petter Selasky
2011-05-23 18:23 ` Guennadi Liakhovetski
2011-05-23 18:29 ` Mauro Carvalho Chehab [this message]
2011-05-23 18:50 ` Hans Petter Selasky
2011-05-26 0:30 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDAA788.80908@redhat.com \
--to=mchehab@redhat.com \
--cc=g.liakhovetski@gmx.de \
--cc=hselasky@c2i.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.