diff for duplicates of <4DDB3A1E.6090206@jp.fujitsu.com> diff --git a/a/1.txt b/N1/1.txt index 2bc7b14..6782bcb 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -66,41 +66,3 @@ thus, rebalance path should try to get free pages. iow, you makes sense. So, I'd like to propose to merge both your and my patch. Thanks. - - ->From 2e77784668f6ca53d88ecb46aa6b99d9d0f33ffa Mon Sep 17 00:00:00 2001 -From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> -Date: Tue, 24 May 2011 13:41:57 +0900 -Subject: [PATCH] vmscan: remove painful micro optimization - -Currently, __alloc_pages_direct_reclaim() call get_page_from_freelist() -only if try_to_free_pages() return !0. - -It's no necessary micro optimization becauase "return 0" mean vmscan reached -priority 0 and didn't get any pages, iow, it's really slow path. But also it -has bad side effect. If we don't call drain_all_pages(), we have a chance to -get infinite loop. - -This patch remove its bad and meaningless micro optimization. - -Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> ---- - mm/page_alloc.c | 3 --- - 1 files changed, 0 insertions(+), 3 deletions(-) - -diff --git a/mm/page_alloc.c b/mm/page_alloc.c -index 1572079..c41d488 100644 ---- a/mm/page_alloc.c -+++ b/mm/page_alloc.c -@@ -1950,9 +1950,6 @@ __alloc_pages_direct_reclaim(gfp_t gfp_mask, unsigned int order, - - cond_resched(); - -- if (unlikely(!(*did_some_progress))) -- return NULL; -- - retry: - page = get_page_from_freelist(gfp_mask, nodemask, order, - zonelist, high_zoneidx, --- -1.7.3.1 diff --git a/a/content_digest b/N1/content_digest index e58dd1e..0d0487d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -83,44 +83,6 @@ "\n" "So, I'd like to propose to merge both your and my patch.\n" "\n" - "Thanks.\n" - "\n" - "\n" - ">From 2e77784668f6ca53d88ecb46aa6b99d9d0f33ffa Mon Sep 17 00:00:00 2001\n" - "From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>\n" - "Date: Tue, 24 May 2011 13:41:57 +0900\n" - "Subject: [PATCH] vmscan: remove painful micro optimization\n" - "\n" - "Currently, __alloc_pages_direct_reclaim() call get_page_from_freelist()\n" - "only if try_to_free_pages() return !0.\n" - "\n" - "It's no necessary micro optimization becauase \"return 0\" mean vmscan reached\n" - "priority 0 and didn't get any pages, iow, it's really slow path. But also it\n" - "has bad side effect. If we don't call drain_all_pages(), we have a chance to\n" - "get infinite loop.\n" - "\n" - "This patch remove its bad and meaningless micro optimization.\n" - "\n" - "Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>\n" - "---\n" - " mm/page_alloc.c | 3 ---\n" - " 1 files changed, 0 insertions(+), 3 deletions(-)\n" - "\n" - "diff --git a/mm/page_alloc.c b/mm/page_alloc.c\n" - "index 1572079..c41d488 100644\n" - "--- a/mm/page_alloc.c\n" - "+++ b/mm/page_alloc.c\n" - "@@ -1950,9 +1950,6 @@ __alloc_pages_direct_reclaim(gfp_t gfp_mask, unsigned int order,\n" - "\n" - " \tcond_resched();\n" - "\n" - "-\tif (unlikely(!(*did_some_progress)))\n" - "-\t\treturn NULL;\n" - "-\n" - " retry:\n" - " \tpage = get_page_from_freelist(gfp_mask, nodemask, order,\n" - " \t\t\t\t\tzonelist, high_zoneidx,\n" - "-- \n" - 1.7.3.1 + Thanks. -e61e7b3b337420084b96a2d159f8c83957a425aa63ce28568dbb425b5f9deaff +ae8ac0f1d44db931e4cdb7119de4513b27fbabf3b8a4a9caa2d44f013039276c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.