From: "Arend van Spriel" <arend@broadcom.com>
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>,
"Dan Carpenter" <error27@gmail.com>
Subject: Re: [RFC] lib: crc8: add new library module providing crc8 algorithm
Date: Tue, 24 May 2011 12:01:33 +0200 [thread overview]
Message-ID: <4DDB81FD.2020903@broadcom.com> (raw)
In-Reply-To: <20110524104404.336c765f@lxorguk.ukuu.org.uk>
On 05/24/2011 11:44 AM, Alan Cox wrote:
> On Tue, 24 May 2011 09:45:47 +0200
> "Arend van Spriel"<arend@broadcom.com> wrote:
>
>> On 05/22/2011 04:19 PM, Alan Cox wrote:
>>> Is it just used for wireless in this form ?
>>>
>>> See the n_gsm and bluetooth code for what I think is the same crc
>>> algorithm but in reverse bit order .
>> Hi Alan,
>>
>> Look into the code in n_gsm and bluetooth code. The algorithm is the
>> same, but except for the bit order it also is using a different
>> polynomial. My current implementation has a fixed table. I could do the
>> table generation runtime with the polynomial and the bit order as
>> parameters. That would make it more general purpose.
> Probably not worth it - its so tiny a piece of code anyway (< 500 bytes
> or so) that it's going to be bigger not smaller if you do that !
Hi Alan,
Not sure whether you mean the source code or the object code. I build
kernel with debug symbols so the sizes are bit higher.
fixed table: -rw-r--r-- 1 arend arend 1859 2011-05-24 11:53 crc8.o
custom table: -rw-r--r-- 1 arend arend 2215 2011-05-24 11:58 crc8.o
The size increase is not that big.
Gr. AvS
--
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --
next prev parent reply other threads:[~2011-05-24 10:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 20:49 [RFC] lib: crc8: add new library module providing crc8 algorithm Arend van Spriel
2011-05-21 22:37 ` Johannes Berg
2011-05-22 8:23 ` Arend van Spriel
2011-05-22 11:23 ` Alan Cox
2011-05-22 12:47 ` Arend van Spriel
2011-05-22 14:19 ` Alan Cox
2011-05-22 15:38 ` Arend van Spriel
2011-05-24 7:45 ` Arend van Spriel
2011-05-24 8:30 ` Arend van Spriel
2011-05-24 9:44 ` Alan Cox
2011-05-24 10:01 ` Arend van Spriel [this message]
2011-05-24 10:25 ` Rafał Miłecki
2011-05-24 10:40 ` Arend van Spriel
2011-05-24 10:27 ` Alan Cox
2011-05-24 10:38 ` Arend van Spriel
2011-05-24 12:57 ` Alan Cox
2011-05-24 17:00 ` Arend van Spriel
-- strict thread matches above, loose matches on Subject: below --
2011-05-22 8:08 Arend van Spriel
2011-05-22 8:59 ` Nicolas Kaiser
2011-05-22 12:49 ` Arend van Spriel
2011-05-24 20:23 Arend van Spriel
2011-05-24 22:52 ` George Spelvin
2011-05-25 5:21 ` Arend van Spriel
2011-05-25 5:46 ` George Spelvin
2011-05-25 6:49 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDB81FD.2020903@broadcom.com \
--to=arend@broadcom.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.