From: Vincent Hanquez <vincent.hanquez@eu.citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Shriram Rajagopalan <rshriram@cs.ubc.ca>,
Jim Fehlig <jfehlig@novell.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 1 of 8] libxc: save/restore: remove static context variables
Date: Tue, 24 May 2011 11:33:05 +0100 [thread overview]
Message-ID: <4DDB8961.60700@eu.citrix.com> (raw)
In-Reply-To: <c43bf40e2f29eb02c7dc.1306228467@cosworth.uk.xensource.com>
On 05/24/2011 10:14 AM, Ian Campbell wrote:
> # HG changeset patch
> # User Ian Campbell<ian.campbell@citrix.com>
> # Date 1306228450 -3600
> # Node ID c43bf40e2f29eb02c7dcf1a2317f243f1af5f659
> # Parent 0727b2fcc33fd5cdf847fde0d2be261be3d6b279
> libxc: save/restore: remove static context variables
>
> 20544:ad9d75d74bd5 and 20545:cc7d66ba0dad seemingly intended to change these
> global static variables into stack variables but didn't remove the static
> qualifier.
>
> Also zero the entire struct once with memset rather than clearing fields
> piecemeal in two different places.
Good catch.
Acked-by-self.
--
Vincent
next prev parent reply other threads:[~2011-05-24 10:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 9:14 [PATCH 0 of 8] Remove static variables from xc_domain_{save, restore}.c Ian Campbell
2011-05-24 9:14 ` [PATCH 1 of 8] libxc: save/restore: remove static context variables Ian Campbell
2011-05-24 10:33 ` Vincent Hanquez [this message]
2011-05-24 9:14 ` [PATCH 2 of 8] libxc: save: drop code under ADAPTIVE_SAVE ifdef Ian Campbell
2011-05-24 9:14 ` [PATCH 3 of 8] libxc: save: rename ratewrite to uncached Ian Campbell
2011-05-24 9:14 ` [PATCH 4 of 8] libxc: save: noncached write doesn't use live parameter Ian Campbell
2011-05-24 9:14 ` [PATCH 5 of 8] libxc: save: move static "write_count" variable into outbuf Ian Campbell
2011-05-24 9:14 ` [PATCH 6 of 8] libxc: save: encapsulate time stats in a struct Ian Campbell
2011-05-24 9:14 ` [PATCH 7 of 8] libxc: save: don't bother calculating stat's deltas unless we are going to print them Ian Campbell
2011-05-24 9:14 ` [PATCH 8 of 8] libxc: save: move static stats variable to stack variable Ian Campbell
2011-05-24 16:45 ` Ian Jackson
2011-05-24 13:47 ` [PATCH 0 of 8] Remove static variables from xc_domain_{save, restore}.c Shriram Rajagopalan
2011-05-24 17:02 ` Ian Jackson
2011-05-24 17:52 ` Ian Campbell
2011-05-24 18:57 ` Shriram Rajagopalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDB8961.60700@eu.citrix.com \
--to=vincent.hanquez@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jfehlig@novell.com \
--cc=rshriram@cs.ubc.ca \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.