From: Paolo Bonzini <pbonzini@redhat.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Avi Kivity <avi@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Sasha Levin <levinsasha928@gmail.com>,
john@jfloren.net, kvm@vger.kernel.org, asias.hejun@gmail.com,
gorcunov@gmail.com, prasadjoshi124@gmail.com
Subject: Re: [PATCH 5/5 V2] kvm tools: Initialize and use VESA and VNC
Date: Tue, 24 May 2011 14:27:24 +0200 [thread overview]
Message-ID: <4DDBA42C.7040208@redhat.com> (raw)
In-Reply-To: <BANLkTim9cvNeBwFMVkurf3pyJWWj8vpK9g@mail.gmail.com>
On 05/24/2011 01:56 PM, Pekka Enberg wrote:
>> > If uint64_t is defined differently than u64, you won't be able to pass it by
>> > reference if an external library expects it.
>
> Oh, the sizes must be the same for obvious reasons so that shouldn't
> be a problem and it's better to do the casting in the external API
> calls than in core code.
Be careful about unsigned long vs. unsigned long long. If you want to
use the u64 spelling that's fine, but I would use a custom header that
defines it from uint64_t.
Paolo
next prev parent reply other threads:[~2011-05-24 12:27 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 11:19 [PATCH 1/5 V2] kvm tools: Add BIOS INT10 handler Sasha Levin
2011-05-23 11:19 ` [PATCH 2/5 V2] kvm tools: Add video mode to kernel initialization Sasha Levin
2011-05-23 11:30 ` Ingo Molnar
2011-05-23 11:19 ` [PATCH 3/5 V2] kvm tools: Add VESA device Sasha Levin
2011-05-23 11:32 ` Ingo Molnar
2011-05-23 11:19 ` [PATCH 4/5 V2] kvm tools: Update makefile and feature tests Sasha Levin
2011-05-23 11:19 ` [PATCH 5/5 V2] kvm tools: Initialize and use VESA and VNC Sasha Levin
2011-05-23 11:38 ` Ingo Molnar
2011-05-23 11:45 ` Pekka Enberg
2011-05-24 8:37 ` Paolo Bonzini
2011-05-24 8:50 ` Ingo Molnar
2011-05-24 9:10 ` Paolo Bonzini
2011-05-24 9:55 ` Pekka Enberg
2011-05-24 11:22 ` Avi Kivity
2011-05-24 11:26 ` Pekka Enberg
2011-05-24 11:30 ` Sasha Levin
2011-05-24 11:30 ` Avi Kivity
2011-05-24 11:38 ` Pekka Enberg
2011-05-24 11:41 ` Avi Kivity
2011-05-24 11:56 ` Pekka Enberg
2011-05-24 12:27 ` Paolo Bonzini [this message]
2011-05-24 14:38 ` Avi Kivity
2011-05-24 14:37 ` Avi Kivity
2011-05-24 14:54 ` Pekka Enberg
2011-05-24 19:03 ` Ingo Molnar
2011-05-24 19:00 ` Ingo Molnar
2011-05-24 19:16 ` Ingo Molnar
2011-05-24 9:18 ` Paolo Bonzini
2011-05-24 19:40 ` Ingo Molnar
2011-05-25 8:21 ` Paolo Bonzini
2011-05-25 8:32 ` Ingo Molnar
2011-05-25 9:15 ` Paolo Bonzini
2011-05-25 9:36 ` Ingo Molnar
2011-05-25 10:01 ` Paolo Bonzini
2011-05-25 10:17 ` Ingo Molnar
2011-05-25 10:44 ` Paolo Bonzini
2011-05-25 12:53 ` Ingo Molnar
2011-05-25 15:37 ` Paolo Bonzini
2011-05-25 9:49 ` Ingo Molnar
2011-05-25 8:38 ` Ingo Molnar
2011-05-24 8:51 ` Cyrill Gorcunov
2011-05-23 14:10 ` Pekka Enberg
2011-05-23 11:29 ` [PATCH 1/5 V2] kvm tools: Add BIOS INT10 handler Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDBA42C.7040208@redhat.com \
--to=pbonzini@redhat.com \
--cc=asias.hejun@gmail.com \
--cc=avi@redhat.com \
--cc=gorcunov@gmail.com \
--cc=john@jfloren.net \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.