All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: dedekind1@gmail.com
Cc: joern@lazybastard.org, dwmw2@infradead.org,
	Robert Jarzmik <robert.jarzmik@atosorigin.com>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: Add DiskOnChip G3 support
Date: Tue, 24 May 2011 15:40:18 +0200	[thread overview]
Message-ID: <4DDBB542.7020506@free.fr> (raw)
In-Reply-To: <1306221756.2785.51.camel@localhost>

On 05/24/2011 09:22 AM, Artem Bityutskiy wrote:
> On Sun, 2011-05-22 at 16:34 +0200, Robert Jarzmik wrote:
>> From: Robert Jarzmik<robert.jarzmik@atosorigin.com>
>>
>> Add support for DiskOnChip G3 chips. The support is quite
>> limited yet :
>>   - no flash writes/erases are implemented
>>   - ECC fixes are not implemented
>>   - powerdown is not implemented
>>   - IPL handling is not yet done
>>
>> On the brighter side, the chip reading does work.
>>
>> Signed-off-by: Robert Jarzmik<robert.jarzmik@atosorigin.com>
> Hi,
>
> the driver looks neat from the first glance, but I did not review it. We
> have just changed mtd partitions API, today. You'll need to amend the
> driver and re-send.
Yes, I have seen them. I'll amend it, no big deal.

I'll wait 1 or 2 weeks for a review, and if nobody steps up, I'll resend 
the amended version for mtd_register stuff, and push for an inclusion 
into -next.

Cheers.

--
Robert

  reply	other threads:[~2011-05-24 13:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-22 14:34 [PATCH] mtd: Add DiskOnChip G3 support Robert Jarzmik
2011-05-24  7:22 ` Artem Bityutskiy
2011-05-24 13:40   ` Robert Jarzmik [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-05-04 22:21 Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDBB542.7020506@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=joern@lazybastard.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=robert.jarzmik@atosorigin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.