All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@ti.com>
To: Ben Gardiner <bengardiner@nanometrics.ca>
Cc: Steven Faludi <stevenfaludi@nanometrics.ca>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	"Nori, Sekhar" <nsekhar@ti.com>,
	"davinci-linux-open-source@linux.davincidsp.com"
	<davinci-linux-open-source@linux.davincidsp.com>,
	Troy Kisky <troy.kisky@boundarydevices.com>
Subject: Re: [PATCH 0/6] ASoC: davinci-pcm: some fixes and convert to BATCH
Date: Wed, 25 May 2011 10:54:45 +0100	[thread overview]
Message-ID: <4DDCD1E5.8010506@ti.com> (raw)
In-Reply-To: <cover.1306258759.git.bengardiner@nanometrics.ca>

On 24/05/11 19:50, Ben Gardiner wrote:
> This patchset is a collection of changes for the davinci-pcm driver that were
> accumulated during previous forays into the davinci-mcasp and davinci-pcm
> drivers [1].
> 
> The first three patches are minor changes that cleanup the ping-pong DMA params
> setup, expand the davinci-pcm reported format and also its maximum channels.
> 
> The fourth patch in the series corrects an audible glitch that can be heard on
> da850evm's McASP when ping-pong buffers are enabled. The glitch occurs only
> on the second and susequent playbacks, not the first. Reversing the order in
> which the dma channels are started and moving the start to the trigger function
> from the prepare function fixes the glitch.
> 
> The fifth and sixth patches in the series convert the davinci-pcm driver to
> BATCH mode. 
> 

All

Acked-by: Liam Girdwood <lrg@ti.com>

One minor thing for patch 6 that can be added incrementally.

  parent reply	other threads:[~2011-05-25  9:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24 18:50 [PATCH 0/6] ASoC: davinci-pcm: some fixes and convert to BATCH Ben Gardiner
2011-05-24 18:50 ` [PATCH 1/6] ASoC: davinci-pcm: trivial: make ping-pong params setup symmetrical Ben Gardiner
2011-05-24 18:50 ` [PATCH 2/6] ASoC: davinci-pcm: expand the .formats Ben Gardiner
2011-05-24 18:50 ` [PATCH 3/6] ASoC: davinci-pcm: increase the maximum channels Ben Gardiner
2011-05-24 18:50 ` [PATCH 4/6] ASoC: davinci-pcm: fix audible glitch on 2nd ping-pong playback Ben Gardiner
2011-05-24 18:50 ` [PATCH 5/6] ASoC: davinci-pcm: extract period elapsed functions Ben Gardiner
2011-05-24 18:50 ` [PATCH 6/6] ASoC: davinci-pcm: convert to BATCH mode Ben Gardiner
2011-05-25  9:52   ` Liam Girdwood
2011-05-25 12:17     ` Ben Gardiner
2011-05-25 13:27     ` [PATCH] ASoC: davinci-pcm: comments for the conversion " Ben Gardiner
2011-05-25 14:19       ` Liam Girdwood
2011-05-25 15:00       ` Mark Brown
2011-05-25  9:54 ` Liam Girdwood [this message]
2011-05-25 11:14 ` [PATCH 0/6] ASoC: davinci-pcm: some fixes and convert to BATCH Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDCD1E5.8010506@ti.com \
    --to=lrg@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bengardiner@nanometrics.ca \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=nsekhar@ti.com \
    --cc=stevenfaludi@nanometrics.ca \
    --cc=troy.kisky@boundarydevices.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.