From: Jens Axboe <axboe@kernel.dk>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] block: fix oops in blk_run_queue()
Date: Wed, 25 May 2011 13:28:41 +0200 [thread overview]
Message-ID: <4DDCE7E9.5090107@kernel.dk> (raw)
In-Reply-To: <1306257531.10201.20.camel@mulgrave.site>
On 2011-05-24 19:18, James Bottomley wrote:
> Bugzilla report is here:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=35682
>
> The problem occurs if blk_run_queue() or its variants is called after
> blk_cleanup_queue() is called. The run checks should have a state guard
> for QUEUE_FLAG_DEAD. Since a DEAD queue is always STOPPED, just fold it
> into the blk_queue_stopped() test.
>
> Signed-off-by: James Bottomley <jbottomley@parallels.com>
>
> ---
>
> Jens, can you look at this, please ... would you prefer a separate DEAD
> test instead? Incidentally, this is in addition to the other DEAD test
> you still haven't applied ...
Seems a bit of a mixup. Would be cleaner to set STOPPED when it is
marked dead, but I suspect that will kill erroring out IO when the
device goes away unless we add some logic to ensure that happens without
the drivers help.
--
Jens Axboe
next prev parent reply other threads:[~2011-05-25 11:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-35282-11613@https.bugzilla.kernel.org/>
2011-05-17 19:17 ` [Bug 35282] BUG() in 2.6.38.6 bugzilla-daemon
2011-05-17 19:55 ` James Bottomley
2011-05-17 20:33 ` bugzilla-daemon
2011-05-19 19:44 ` bugzilla-daemon
2011-05-21 20:30 ` James Bottomley
2011-05-24 17:18 ` [PATCH] block: fix oops in blk_run_queue() James Bottomley
2011-05-25 11:28 ` Jens Axboe [this message]
2011-05-21 20:31 ` [Bug 35282] BUG() in 2.6.38.6 bugzilla-daemon
2011-05-21 21:40 ` bugzilla-daemon
2011-05-27 9:53 ` bugzilla-daemon
2011-05-28 16:56 ` James Bottomley
2011-05-28 16:57 ` bugzilla-daemon
2011-06-12 20:54 ` bugzilla-daemon
2011-06-12 20:55 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDCE7E9.5090107@kernel.dk \
--to=axboe@kernel.dk \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.