From: Michal Marek <mmarek@suse.cz>
To: Maximilian Pasternak <m.kbuild@bluescreen.de>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: kernel build issue whith "make tar-pkg" with INSTALL_FW_PATH [patch included]
Date: Wed, 25 May 2011 14:30:03 +0200 [thread overview]
Message-ID: <4DDCF64B.2030802@suse.cz> (raw)
In-Reply-To: <20110524202935.CF171D602BD@dd12738.kasserver.com>
On 24.5.2011 22:29, Maximilian Pasternak wrote:
> building a kernel package with
> | make tar-pkg INSTALL_FW_PATH=/somewhere
>
>
> Expected result:
> ----------------
> * tar-archive including the firmware in folder /somehere
I don't think that this should be supported, the firmware needs to be
installed below /lib/firmware, which is where udev expects it.
> Makefile:
> | # Firmware install
> | INSTALL_FW_PATH=$(INSTALL_MOD_PATH)/lib/firmware
^^^^^^^^^^^^^^^^
> | export INSTALL FW PATH
> ...
> | firmware_install: FORCE
> | @mkdir -p $(objtree)/firmware
> | $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.fwinst obj=firmware
> __fw_install
>
> Here INSTALL_MOD_PATH is not considered but is needed for packageing.
Why do you think that INSTALL_MOD_PATH is not considered?
> Potential fix:
> --------------
>
> --- BEGIN PATCH -------------------------------------------------------
> diff -ur linux-2.6.38_orig/Makefile linux-2.6.38/Makefile
> --- linux-2.6.38_orig/Makefile 2011-03-13 18:24:19.000000000 +0200
> +++ linux-2.6.38/Makefile 2011-03-13 18:31:05.000000000 +0200
> @@ -1028,8 +1028,9 @@
>
> #
> ---------------------------------------------------------------------------
> # Firmware install
> -INSTALL_FW_PATH=$(INSTALL_MOD_PATH)/lib/firmware
> -export INSTALL_FW_PATH
> +INSTALL_FW_PATH=/lib/firmware
> +INSTALL_FW_TO_PATH=$(INSTALL_MOD_PATH)$(INSTALL_FW_PATH)
> +export INSTALL_FW_TO_PATH
You're changing the semantics of INSTALL_FW_PATH, breaking it for people
who might have been using it. BTW, the patch is corrupt, spaces before
context lines are missing and long lines are broken.
Michal
next prev parent reply other threads:[~2011-05-25 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 20:29 kernel build issue whith "make tar-pkg" with INSTALL_FW_PATH [patch included] Maximilian Pasternak
2011-05-25 12:30 ` Michal Marek [this message]
2011-05-25 12:33 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDCF64B.2030802@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=m.kbuild@bluescreen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.