From: Hannes Reinecke <hare@suse.de>
To: christophe.varoqui@opensvc.com
Cc: device-mapper development <dm-devel@redhat.com>,
Christophe Varoqui <christophe.varoqui@gmail.com>
Subject: Re: SUSE multipath-tools patch resync
Date: Wed, 25 May 2011 14:45:39 +0200 [thread overview]
Message-ID: <4DDCF9F3.50807@suse.de> (raw)
In-Reply-To: <1306326126.2290.33.camel@lapoo.opensvc.com>
On 05/25/2011 02:22 PM, Christophe Varoqui wrote:
>> Well, forget it ... it was just a matter of 'make clean&& make' as some
>> structures changed length.
>>
>> The merge is over and pushed to korg.
>> I catched only to problems.
>> You might want to review the fixes.
>>
> Hmm, there might be other problems.
>
> on a 'multipathd reconfigure' command, the uxclient gets stuck and the
> multipathd daemon strace shows:
>
> $ sudo strace -f -p 17721
> Process 17721 attached with 7 threads - interrupt to quit
> [pid 17757] futex(0x7fdc6a1540a4, FUTEX_WAIT_PRIVATE, 3, NULL
> <unfinished ...>
> [pid 17756] futex(0x11167f0, FUTEX_WAIT_PRIVATE, 2, NULL
> <unfinished ...>
> [pid 17755] ioctl(3, DM_DEV_WAIT<unfinished ...>
> [pid 17724] futex(0x11167f0, FUTEX_WAIT_PRIVATE, 2, NULL
> <unfinished ...>
> [pid 17723] recvmsg(6,<unfinished ...>
> [pid 17722] futex(0x110a1b4, FUTEX_WAIT_PRIVATE, 15, NULL
> <unfinished ...>
> [pid 17721] futex(0x612624, FUTEX_WAIT_PRIVATE, 1, NULL
>
I've just send some more fixes which have been uncovered during
recent tests.
- Use refcounting for sysfs devices: We do use sysdev_get() and
sysdev_put(), but forgot to refcount them. So occasionally
uevents would try to call sysdev_put() on already freed devices.
- Race condition during shutdown with stop_waiter_thread():
Trying to access anything inside the waiter structure is
suicidal, as the waiter thread might be gone at any time.
- Do not handle external renames from multipathd thread:
Fallout from the above patch; and what's more, the external
rename should be handled by the waiter thread already.
So no point in doing so from the daemon itself.
Patches should appear on the mailing list pretty soon.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2011-05-25 12:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 15:03 SUSE multipath-tools patch resync Hannes Reinecke
2011-05-20 6:26 ` Christophe Varoqui
2011-05-25 7:51 ` Christophe Varoqui
2011-05-25 9:08 ` Hannes Reinecke
2011-05-25 11:14 ` Christophe Varoqui
2011-05-25 12:10 ` Christophe Varoqui
2011-05-25 12:22 ` Christophe Varoqui
2011-05-25 12:45 ` Hannes Reinecke [this message]
2011-05-25 21:29 ` Christophe Varoqui
2011-05-26 6:28 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDCF9F3.50807@suse.de \
--to=hare@suse.de \
--cc=christophe.varoqui@gmail.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.