From: Jonathan Cameron <jic23@cam.ac.uk>
To: michael.hennerich@analog.com
Cc: linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org, drivers@analog.com
Subject: Re: [PATCH] iio: industrialio-trigger: set iio_poll_func private_data
Date: Wed, 25 May 2011 13:48:41 +0100 [thread overview]
Message-ID: <4DDCFAA9.6010101@cam.ac.uk> (raw)
In-Reply-To: <1306319952-24722-1-git-send-email-michael.hennerich@analog.com>
On 05/25/11 11:39, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> Failure to set iio_poll_func private_data, causes zero pointer access
> violations in all consumer trigger handlers.
Yikes. Good spot. Not one of my better bits of refactoring. Strange
thing is I could have sworn I tested that, but it clearly won't work
without your fix..
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
> drivers/staging/iio/industrialio-trigger.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/iio/industrialio-trigger.c b/drivers/staging/iio/industrialio-trigger.c
> index 6159023..d504aa2 100644
> --- a/drivers/staging/iio/industrialio-trigger.c
> +++ b/drivers/staging/iio/industrialio-trigger.c
> @@ -294,6 +294,7 @@ struct iio_poll_func
> pf->h = h;
> pf->thread = thread;
> pf->type = type;
> + pf->private_data = private;
>
> return pf;
> }
next prev parent reply other threads:[~2011-05-25 12:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 10:39 [PATCH] iio: industrialio-trigger: set iio_poll_func private_data michael.hennerich
2011-05-25 12:48 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-25 12:42 michael.hennerich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDCFAA9.6010101@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.