All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Soltys <soltys-R61QfzASbfY@public.gmane.org>
To: Karel Zak <kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/5] 95fstab-sys: use det_fs and wrap_fsck
Date: Wed, 25 May 2011 16:32:43 +0200	[thread overview]
Message-ID: <4DDD130B.90602@ziu.info> (raw)
In-Reply-To: <20110524223936.GG2659-sHeGUpI7y9L/9pzu0YdTqQ@public.gmane.org>

W dniu 25.05.2011 00:39, Karel Zak pisze:
>
>   from mount(8) code:
>
>     need_escaping[] = { ' ', '\t', '\n', '\\' };
>
>   It's used for all strings in fstab (so not for mountpoints only).
>
>> Also, some standard handling uuid/label and watching for other stuff as
>> well would be good too. Plain 'test -e' is not too proper either.
>
>    From my point of view it would be ideal to avoid fstab parsing in the
>   script at all.
>
>   export FSTAB_FILE=/etc/fstab.sys
>
>   for $dev in $(findmnt --fstab -o SOURCE -e -n -O no_netdev); do
>
>      fsck -T $dev
>      mount $dev --target-prefix $NEWROOT
>
>   done
>
>   Unfortunately mount(8) does not allow to read info about mountpoints
>   from alternative fstab file and it does not support --target-prefix
>   now.  I'll add this to my TODO list.
>
>      Karel
>

Ok, thanks for info (btw, findmnt seems to only handle octal escapes).

I'll update fstab-sys & co. and send new set of patches.

  parent reply	other threads:[~2011-05-25 14:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-20 15:09 [RFC/PATCH] Expand fstab-sys, simplify rootfs-block Michal Soltys
     [not found] ` <1305904167-14199-1-git-send-email-soltys-R61QfzASbfY@public.gmane.org>
2011-05-20 15:09   ` [PATCH 1/5] dracut-lib.sh: add vwarn() function Michal Soltys
2011-05-20 15:09   ` [PATCH 2/5] dracut-lib.sh: Add det_fs() and wrap_fsck() Michal Soltys
2011-05-20 15:09   ` [PATCH 3/5] 95fstab-sys: use det_fs and wrap_fsck Michal Soltys
     [not found]     ` <1305904167-14199-4-git-send-email-soltys-R61QfzASbfY@public.gmane.org>
2011-05-23 23:05       ` Karel Zak
     [not found]         ` <20110523230507.GC2659-sHeGUpI7y9L/9pzu0YdTqQ@public.gmane.org>
2011-05-24 20:50           ` Michal Soltys
     [not found]             ` <4DDC1A05.9030400-R61QfzASbfY@public.gmane.org>
2011-05-24 22:39               ` Karel Zak
     [not found]                 ` <20110524223936.GG2659-sHeGUpI7y9L/9pzu0YdTqQ@public.gmane.org>
2011-05-25 13:16                   ` Harald Hoyer
2011-05-25 14:32                   ` Michal Soltys [this message]
     [not found]                 ` <4DDD0E48.3060607@rasengan.ppgk.com.pl>
     [not found]                   ` <4DDD0E48.3060607-dAhJnYnFfKxY6LDf3zcCrARSaAK4NQh3@public.gmane.org>
2011-05-25 14:33                     ` Karel Zak
     [not found]                       ` <20110525143311.GA14298-sHeGUpI7y9L/9pzu0YdTqQ@public.gmane.org>
2011-05-29  0:38                         ` [RFC] fstab-sys: concept Michal Soltys
2011-05-25 14:31           ` [PATCH 3/5] 95fstab-sys: use det_fs and wrap_fsck Karel Zak
2011-05-20 15:09   ` [PATCH 4/5] 95rootfs-block/mount-root.sh: Rely on " Michal Soltys
2011-05-20 15:09   ` [PATCH 5/5] 95rootfs-block/block-genrules.sh: Use > instead of >> Michal Soltys

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDD130B.90602@ziu.info \
    --to=soltys-r61qfzasbfy@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.