From: David Daney <ddaney@caviumnetworks.com>
To: Jian Peng <jipeng@broadcom.com>
Cc: "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: patch to support topdown mmap allocation in MIPS
Date: Wed, 25 May 2011 10:58:05 -0700 [thread overview]
Message-ID: <4DDD432D.4020200@caviumnetworks.com> (raw)
In-Reply-To: <E18F441196CA634DB8E1F1C56A50A874572CCBB6B5@IRVEXCHCCR01.corp.ad.broadcom.com>
On 05/25/2011 10:47 AM, Jian Peng wrote:
> Hi, Ralf/David,
>
> What else should I do to get this patch merged?
>
Be patient. And tell how it was tested.
Also ....
[...]
> +
> +unsigned long arch_get_unmapped_area_foo(struct file *filp, unsigned long addr0,
> + unsigned long len, unsigned long pgoff, unsigned long flags,
> + enum mmap_allocation_direction dir)
I know I suggested the name *_foo, but really I expected you to choose a
better name, as the 'foo' is just the default name for examples.
I think it needs a better name than that.
I will try to test it on my Octeon system sometime.
David Daney
next prev parent reply other threads:[~2011-05-25 17:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 21:09 patch to support topdown mmap allocation in MIPS Jian Peng
2011-05-16 23:37 ` Jian Peng
2011-05-17 0:12 ` David Daney
2011-05-17 1:06 ` Jian Peng
2011-05-17 16:49 ` David Daney
2011-05-17 19:37 ` Jian Peng
2011-05-25 17:47 ` Jian Peng
2011-05-25 17:58 ` David Daney [this message]
2011-05-25 18:06 ` Jian Peng
2011-06-13 23:43 ` Jian Peng
2011-06-14 0:21 ` Jian Peng
2011-11-09 17:45 ` Ralf Baechle
2011-05-17 1:27 ` Kevin Cernekee
2011-05-17 4:04 ` Jian Peng
2011-05-17 15:18 ` [PATCH] MIPS: Cleanup arch_get_unmapped_area Ralf Baechle
2011-05-17 16:52 ` patch to support topdown mmap allocation in MIPS Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDD432D.4020200@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=jipeng@broadcom.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.