All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Hans Petter Selasky <hselasky@c2i.net>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH] The USB_SPEED... keywords are already defined by the USB stack. Rename currently unused macros to avoid possible future warnings and errors.
Date: Wed, 25 May 2011 21:10:50 -0300	[thread overview]
Message-ID: <4DDD9A8A.3020109@redhat.com> (raw)
In-Reply-To: <201105231319.11284.hselasky@c2i.net>

Em 23-05-2011 08:19, Hans Petter Selasky escreveu:
> --HPS
> 
> 
> dvb-usb-0001.patch
> 
> 
> From f7a0f7254da47ff88f69314f14043b01ba0764eb Mon Sep 17 00:00:00 2001
> From: Hans Petter Selasky <hselasky@c2i.net>
> Date: Mon, 23 May 2011 12:43:50 +0200
> Subject: [PATCH] The USB_SPEED_XXX keywords are already defined by the USB stack. Rename currently unused macros to avoid possible future warnings and errors.
> 
> Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
> ---
>  drivers/media/dvb/dvb-usb/gp8psk.h |    6 +++---
>  drivers/media/dvb/dvb-usb/vp7045.h |    6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/media/dvb/dvb-usb/gp8psk.h b/drivers/media/dvb/dvb-usb/gp8psk.h
> index 831749a..c271b68 100644
> --- a/drivers/media/dvb/dvb-usb/gp8psk.h
> +++ b/drivers/media/dvb/dvb-usb/gp8psk.h
> @@ -78,9 +78,9 @@ extern int dvb_usb_gp8psk_debug;
>  #define ADV_MOD_DVB_BPSK 9     /* DVB-S BPSK */
>  
>  #define GET_USB_SPEED                     0x07
> - #define USB_SPEED_LOW                    0
> - #define USB_SPEED_FULL                   1
> - #define USB_SPEED_HIGH                   2
> + #define TH_USB_SPEED_LOW                 0
> + #define TH_USB_SPEED_FULL                1
> + #define TH_USB_SPEED_HIGH                2
>  
>  #define RESET_FX2                         0x13
>  
> diff --git a/drivers/media/dvb/dvb-usb/vp7045.h b/drivers/media/dvb/dvb-usb/vp7045.h
> index 969688f..7ce6c00 100644
> --- a/drivers/media/dvb/dvb-usb/vp7045.h
> +++ b/drivers/media/dvb/dvb-usb/vp7045.h
> @@ -36,9 +36,9 @@
>   #define Tuner_Power_OFF                  0
>  
>  #define GET_USB_SPEED                     0x07
> - #define USB_SPEED_LOW                    0
> - #define USB_SPEED_FULL                   1
> - #define USB_SPEED_HIGH                   2
> + #define TH_USB_SPEED_LOW                 0
> + #define TH_USB_SPEED_FULL                1
> + #define TH_USB_SPEED_HIGH                2
>  
>  #define LOCK_TUNER_COMMAND                0x09


Nah. Those vars are unused on those drivers. Just remove them.

Thanks!
Mauro.

      reply	other threads:[~2011-05-26  0:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-23 11:19 [PATCH] The USB_SPEED... keywords are already defined by the USB stack. Rename currently unused macros to avoid possible future warnings and errors Hans Petter Selasky
2011-05-26  0:10 ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDD9A8A.3020109@redhat.com \
    --to=mchehab@redhat.com \
    --cc=hselasky@c2i.net \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.