From: Li Zefan <lizf@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
liubo <liubo2009@cn.fujitsu.com>,
Linux Btrfs <linux-btrfs@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Chris Mason <chris.mason@oracle.com>
Subject: Re: [PATCH 1/2] tracing: add __print_symbolic_u64 to avoid warnings on 32bit machine
Date: Thu, 26 May 2011 09:08:05 +0800 [thread overview]
Message-ID: <4DDDA7F5.9020001@cn.fujitsu.com> (raw)
In-Reply-To: <1306342064.1465.101.camel@gandalf.stny.rr.com>
Steven Rostedt wrote:
> On Wed, 2011-05-25 at 09:12 -0700, Randy Dunlap wrote:
>>
>>> But what I sent out previously is not going into 2.6.40 anyway. Ingo
>>> feels that it's too late in the merge window to pull those changes and
>>> wants to wait till the next merge window. Since there's some fixes in
>>> that pull request, I'll need to cherry pick them out and rebase the rest
>>> for the next window.
>>
>> Sorry to hear all of that. This fix is needed in mainline.
>>
>
> Hmm, it is a warning fix. Well, I could add this to the cherry picking
> I'm doing (fixes only).
>
> I'm currently making a fix for a triple fault in the function tracer
> caused by PROVE_RCU causing recursive tracing. When I get this fixed,
> I'll be pushing the "fixes" next.
>
Actually it's more than a compile warning fix.
After a variable is cast from u64 to u32 and passed to __print_symbolic(),
we'll see incorrect result in the trace output.
next prev parent reply other threads:[~2011-05-26 1:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 6:42 [RFC PATCH] Trace: use unsigned long long in trace print frames liubo
2011-04-01 13:49 ` Steven Rostedt
2011-04-02 1:41 ` liubo
2011-04-06 9:18 ` [PATCH] Trace: add __print_symbolic_u64 to avoid warnings on 32bit machine liubo
2011-04-15 16:24 ` Randy Dunlap
2011-04-15 16:37 ` Christoph Hellwig
2011-04-18 18:11 ` Steven Rostedt
2011-04-19 1:08 ` liubo
2011-04-19 1:35 ` [PATCH 1/2] tracing: " liubo
2011-04-29 10:01 ` liubo
2011-05-01 15:35 ` Steven Rostedt
2011-05-26 5:49 ` liubo
2011-05-25 12:27 ` Steven Rostedt
2011-05-25 16:12 ` Randy Dunlap
2011-05-25 16:47 ` Steven Rostedt
2011-05-25 16:50 ` Randy Dunlap
2011-05-26 1:08 ` Li Zefan [this message]
2011-05-26 1:17 ` Steven Rostedt
2011-05-27 12:48 ` [tip:perf/urgent] tracing: Add " tip-bot for liubo
2011-04-19 1:35 ` [PATCH 2/2] tracing: update btrfs's tracepoints to use u64 interface liubo
2011-05-27 12:48 ` [tip:perf/urgent] tracing: Update " tip-bot for liubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDDA7F5.9020001@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
--cc=randy.dunlap@oracle.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.