From: Ding Dinghua <dingdinghua@nrchpc.ac.cn>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] Jbd2: fix a bug of leaking jh->b_jcount
Date: Thu, 26 May 2011 19:25:09 +0800 [thread overview]
Message-ID: <4DDE3895.3060602@nrchpc.ac.cn> (raw)
In-Reply-To: <20110525221415.GE9520@thunk.org>
Hi Ted,
thanks for your suggestion, i have resent the patches, please have a look.
Ted Ts'o wrote:
> On Wed, May 25, 2011 at 06:49:57PM +0800, Yongqiang Yang wrote:
>
>> Signed-off-by: line was missed.
>>
>
> Ding,
>
> Please resend the patch with the Signed-off-by, or tell me explicitly
> that it's OK to add:
>
> Signed-off-by: Ding Dinghua <dingdinghua@nrchpc.ac.cn>
>
> The signed-off-by has legal meaning (see below) so it's not something
> I want to add on my own initiative without getting an explicit ack
> from the original author.
>
> Regards,
>
> - Ted
>
> (From /usr/src/linux/Documentation/SubmittingPatches)
>
> 12) Sign your work
>
> To improve tracking of who did what, especially with patches that can
> percolate to their final resting place in the kernel through several
> layers of maintainers, we've introduced a "sign-off" procedure on
> patches that are being emailed around.
>
> The sign-off is a simple line at the end of the explanation for the
> patch, which certifies that you wrote it or otherwise have the right to
> pass it on as a open-source patch. The rules are pretty simple: if you
> can certify the below:
>
> Developer's Certificate of Origin 1.1
>
> By making a contribution to this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
> have the right to submit it under the open source license
> indicated in the file; or
>
> (b) The contribution is based upon previous work that, to the best
> of my knowledge, is covered under an appropriate open source
> license and I have the right under that license to submit that
> work with modifications, whether created in whole or in part
> by me, under the same open source license (unless I am
> permitted to submit under a different license), as indicated
> in the file; or
>
> (c) The contribution was provided directly to me by some other
> person who certified (a), (b) or (c) and I have not modified
> it.
>
> (d) I understand and agree that this project and the contribution
> are public and that a record of the contribution (including all
> personal information I submit with it, including my sign-off) is
> maintained indefinitely and may be redistributed consistent with
> this project or the open source license(s) involved.
>
> then you just add a line saying
>
> Signed-off-by: Random J Developer <random@developer.example.org>
>
> using your real name (sorry, no pseudonyms or anonymous contributions.)
>
> Some people also put extra tags at the end. They'll just be ignored for
> now, but you can do this to mark internal company procedures or just
> point out some special detail about the sign-off.
>
>
next prev parent reply other threads:[~2011-05-26 11:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <-1724257416234743088@unknownmsgid>
2011-05-25 10:49 ` [PATCH 1/2] Jbd2: fix a bug of leaking jh->b_jcount Yongqiang Yang
2011-05-25 12:02 ` Theodore Tso
2011-05-25 22:14 ` Ted Ts'o
2011-05-26 11:25 ` Ding Dinghua [this message]
2011-05-26 2:28 [PATCH 1/2] jbd2: " Ding Dinghua
2011-05-26 15:16 ` Ted Ts'o
-- strict thread matches above, loose matches on Subject: below --
2011-05-26 2:02 dingdinghua
2011-05-26 2:10 ` 丁定华
2011-05-25 10:19 [PATCH 1/2] Jbd2: " y
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDE3895.3060602@nrchpc.ac.cn \
--to=dingdinghua@nrchpc.ac.cn \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.