Re: [Qemu-devel] [PATCH] host-pcc: enable building with -m32 or -m64

[Stefan Berger <stefanb@linux.vnet.ibm.com>]

On 05/26/2011 04:20 PM, Andreas Färber wrote:
> Am 26.05.2011 um 21:00 schrieb Stefan Berger:
>
>> With the below patch I can build either ppc (-m32) or ppc64 (-m64) 
>> versions of Qemu (on a ppc64 host) when passing these compiler flags 
>> via 'configure ... --extra-cflags="-m32"'.
>
> You probably meant "without passing"?
>
> Nack. Please don't hardcode -mXX in configure, it's -arch ppc vs. 
> -arch ppc64 on my host/gcc. What's wrong with passing --extra-cflags?
>
I posted the following patch today for compiling libcacard with -m32 on 
a 64 bit machine.

http://lists.nongnu.org/archive/html/qemu-devel/2011-05/msg02909.html

It adds LDFLAGS. This works fine on x86-64. Then trying this out on 
ppc64 with -m32 in extra-cflags I find the following in config-host.mak

[...]
HELPER_CFLAGS=
LDFLAGS=-Wl,--warn-common -g
ARLIBS_BEGIN=
[...]

The -m32 doesn't make it into LDFLAGS. The below patch fixed it for me 
following the pattern of x86-64 and i686 a bit further up in the case 
statement in configure.

    Stefan

> Andreas
>
>> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
>>
>> ---
>> configure |    9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> Index: qemu-git/configure
>> ===================================================================
>> --- qemu-git.orig/configure
>> +++ qemu-git/configure
>> @@ -807,7 +807,14 @@ case "$cpu" in
>>     arm*)
>>            host_guest_base="yes"
>>            ;;
>> -    ppc*)
>> +    ppc)
>> +           QEMU_CFLAGS="-m32 $QEMU_CFLAGS"
>> +           LDFLAGS="-m32 $LDFLAGS"
>> +           host_guest_base="yes"
>> +           ;;
>> +    ppc64)
>> +           QEMU_CFLAGS="-m64 $QEMU_CFLAGS"
>> +           LDFLAGS="-m64 $LDFLAGS"
>>            host_guest_base="yes"
>>            ;;
>>     mips*)
>
>
>