From: Nathan Whitehorn <788697@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Bug 788697] Re: [PowerPC] [patch] mtmsr does not preserve high bits of MSR
Date: Thu, 26 May 2011 23:33:14 -0000 [thread overview]
Message-ID: <4DDEE33A.3080100@freebsd.org> (raw)
In-Reply-To: 589FAE95-5CD6-482C-83F3-AF1FF301D854@suse.de
On 05/26/11 11:45, agraf wrote:
> On 26.05.2011, at 18:09, Nathan Whitehorn wrote:
>
>> ** Patch added: "mtmstr.diff"
>> https://bugs.launchpad.net/bugs/788697/+attachment/2143748/+files/mtmstr.diff
>>
>> --
>> You received this bug notification because you are a member of qemu-
>> devel-ml, which is subscribed to QEMU.
>> https://bugs.launchpad.net/bugs/788697
>>
>> Title:
>> [PowerPC] [patch] mtmsr does not preserve high bits of MSR
>>
>> Status in QEMU:
>> New
>>
>> Bug description:
>> The mtmsr instruction on 64-bit PPC does not preserve the high-order
>> 32-bits of the MSR the way it is supposed to, instead setting them to
>> 0, which takes 64-bit code out of 64-bit mode. There is some code that
>> does the right thing, but it brokenly only preserves these bits when
>> the thread is not in 64-bit mode (i.e. when it doesn't matter). The
>> attached patch unconditionally enables this code when TARGET_PPC64 is
>> set, per the ISA spec, which fixes early boot failures trying to start
>> FreeBSD/powerpc64 under qemu.
>>
>
> Please send the patch as proper patch to the ML and CC me.
What isn't proper about the patch? I'm happy to re-email it, but don't
want things to be in the wrong format.
-Nathan
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/788697
Title:
[PowerPC] [patch] mtmsr does not preserve high bits of MSR
Status in QEMU:
New
Bug description:
The mtmsr instruction on 64-bit PPC does not preserve the high-order
32-bits of the MSR the way it is supposed to, instead setting them to
0, which takes 64-bit code out of 64-bit mode. There is some code that
does the right thing, but it brokenly only preserves these bits when
the thread is not in 64-bit mode (i.e. when it doesn't matter). The
attached patch unconditionally enables this code when TARGET_PPC64 is
set, per the ISA spec, which fixes early boot failures trying to start
FreeBSD/powerpc64 under qemu.
next prev parent reply other threads:[~2011-05-26 23:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 16:09 [Qemu-devel] [Bug 788697] [NEW] [PowerPC] [patch] mtmsr does not preserve high bits of MSR Nathan Whitehorn
2011-05-26 16:09 ` [Qemu-devel] [Bug 788697] " Nathan Whitehorn
2011-05-26 16:45 ` Alexander Graf
2011-05-26 23:33 ` Nathan Whitehorn [this message]
2011-05-26 23:47 ` Alexander Graf
2011-05-31 13:35 ` Nathan Whitehorn
2011-05-31 13:49 ` Alexander Graf
2012-08-03 3:06 ` Samuel Bronson
2016-05-23 19:40 ` thh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDEE33A.3080100@freebsd.org \
--to=788697@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.