All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann Dupont <Yann.Dupont@univ-nantes.fr>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Arun Sharma <asharma@fb.com>, David Miller <davem@davemloft.net>,
	Maximilian Engelhardt <maxi@daemonizer.de>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	StuStaNet Vorstand <vorstand@stusta.mhn.de>,
	Denys Fedoryshchenko <denys@visp.net.lb>
Subject: Re: Kernel crash after using new Intel NIC (igb)
Date: Fri, 27 May 2011 09:56:44 +0200	[thread overview]
Message-ID: <4DDF593C.3060900@univ-nantes.fr> (raw)
In-Reply-To: <1306466831.2543.58.camel@edumazet-laptop>

Le 27/05/2011 05:27, Eric Dumazet a écrit :
> Le jeudi 26 mai 2011 à 17:09 -0700, Arun Sharma a écrit :
>> On 5/26/11 3:01 PM, Eric Dumazet wrote:
>>
>>
>>>> Yeah - using the refcnt seems better than list_empty(), but I'm not sure
>>>> that your patch addresses the race above.
>>> It does.
>> True. I can't find any holes in this method and it resolves the "failure
>> to unlink from unused" case.
>>
>> Perhaps wrap the while(1) loop into its own primitive in atomic.h or use
>> an existing primitive?
>>
> Sure, here is a formal submission I cooked.
>
> Thanks
>
> [PATCH] inetpeer: fix race in unused_list manipulations

Thanks eric, didn't noticed this thread, nice to see you squashed this bug.
As you said in a previous message, slub_nomerge prevented us from 
crashing for 113 days now :)

But of course, THE REAL FIX is much preffered. Will try this patch with 
the next -stable update.

Thanks for your efforts,

-- 
Yann Dupont - Service IRTS, DSI Université de Nantes
Tel : 02.53.48.49.20 - Mail/Jabber : Yann.Dupont@univ-nantes.fr


  reply	other threads:[~2011-05-27  7:59 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-24 22:32 Kernel crash after using new Intel NIC (igb) Maximilian Engelhardt
2011-04-26 23:34 ` Wyborny, Carolyn
2011-04-26 23:34   ` Wyborny, Carolyn
2011-04-27 11:46   ` Maximilian Engelhardt
2011-04-27 12:04     ` Eric Dumazet
2011-04-27  4:24 ` Eric Dumazet
2011-04-27  4:32   ` Eric Dumazet
2011-04-27 11:51     ` Maximilian Engelhardt
2011-05-12 21:10       ` Arun Sharma
2011-05-12 21:15         ` Eric Dumazet
2011-05-24 21:33           ` Arun Sharma
2011-05-25  2:44             ` Eric Dumazet
2011-05-25  6:06               ` Arun Sharma
2011-05-25  6:35                 ` Eric Dumazet
2011-05-26 15:06                   ` Ben Hutchings
2011-05-26 19:30                   ` Arun Sharma
2011-05-26 19:47                     ` Eric Dumazet
2011-05-26 21:48                       ` Arun Sharma
2011-05-26 22:01                         ` Eric Dumazet
2011-05-27  0:09                           ` Arun Sharma
2011-05-27  3:27                             ` Eric Dumazet
2011-05-27  7:56                               ` Yann Dupont [this message]
2011-05-27 17:40                               ` David Miller
2011-05-27 17:52                               ` Arun Sharma
2011-05-27 19:56                                 ` Eric Dumazet
2011-05-27 21:14                                   ` Arun Sharma
2011-05-28  5:41                                     ` Eric Dumazet
2011-05-28 18:04                                       ` Ingo Molnar
2011-05-29  7:33                                         ` Eric Dumazet
2011-05-29  7:38                                           ` Ingo Molnar
2011-05-29  7:43                                             ` Eric Dumazet
2011-05-29 12:33                                               ` Ingo Molnar
2011-05-30 18:34                                                 ` Arun Sharma
2011-05-31 10:50                                                   ` Ingo Molnar
2011-07-13 13:38                               ` Maximilian Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDF593C.3060900@univ-nantes.fr \
    --to=yann.dupont@univ-nantes.fr \
    --cc=asharma@fb.com \
    --cc=davem@davemloft.net \
    --cc=denys@visp.net.lb \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxi@daemonizer.de \
    --cc=netdev@vger.kernel.org \
    --cc=vorstand@stusta.mhn.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.