From: "H. Peter Anvin" <hpa@zytor.com>
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, mingo@elte.hu
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86, asm: Clean up desc.h a bit
Date: Fri, 27 May 2011 10:03:20 -0700 [thread overview]
Message-ID: <4DDFD958.9090700@zytor.com> (raw)
In-Reply-To: <tip-incpt6y26yd8586idx65t9ll@git.kernel.org>
On 05/27/2011 01:39 AM, tip-bot for Ingo Molnar wrote:
> Commit-ID: 9a3865b185e77d1a4ca2d8356e37c19b78168961
> Gitweb: http://git.kernel.org/tip/9a3865b185e77d1a4ca2d8356e37c19b78168961
> Author: Ingo Molnar <mingo@elte.hu>
> AuthorDate: Fri, 27 May 2011 09:29:32 +0200
> Committer: Ingo Molnar <mingo@elte.hu>
> CommitDate: Fri, 27 May 2011 09:30:50 +0200
>
> x86, asm: Clean up desc.h a bit
>
> I have looked at this file and found it rather ugly - improve
> readability a bit. No change in functionality.
>
It sure is, but let me also register for the record that I hate the
bloody bitfield. A lot of what the bitfield does is completely
pointless (breaking down the type field, which really is nothing other
than a magic constant as far as the kernel is anyway) and generates
insanely bad code.
I honestly think if we used macros like GDT_ENTRY() and perhaps a few
variants we would make the code simpler.
-hpa
next prev parent reply other threads:[~2011-05-27 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 8:39 [tip:x86/urgent] x86, asm: Clean up desc.h a bit tip-bot for Ingo Molnar
2011-05-27 17:03 ` H. Peter Anvin [this message]
2011-05-27 17:12 ` Ingo Molnar
2011-05-27 17:14 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDFD958.9090700@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.