From: Elizabeth Flanagan <elizabeth.flanagan@intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 0/1][v3] license.bbclass parsing changes rebased sans debug
Date: Sat, 28 May 2011 16:31:10 -0700 [thread overview]
Message-ID: <4DE185BE.7000905@intel.com> (raw)
In-Reply-To: <4DE161C7.7040908@gmail.com>
On 05/28/2011 01:57 PM, Khem Raj wrote:
> On 5/28/2011 10:54 AM, Elizabeth Flanagan wrote:
>> In this case, elfutils should probably be changes as well as
>> license.bbclass. As do_populate_lic is looking for valid python to make
>> a syntax tree from, this will fail. Solution:
>>
>> 1. Fix license.bbclass to check LICENSE and massage it a bit more.
>> 2. Fix elfutils to be GPLv2* (unless it's the GCC exception. I haven't
>> read the license yet).
>
> It does not like () around license values so simple solution is to replace
>
> -LICENSE = "(GPLv2& Exception)"
> +LICENSE = "GPLv2& Exception"
>
> Generally its preferable to fix eflutils first before license class in
> this case to keep the tree bisect'able.
>
Actually, the issue is my .replace("(", " ( "). It makes the string " ( 'GPLv2' & 'Exception' ) " which tosses an error
because of the indented string. I have a fix I'm putting a pull request in (in about 10 minutes) for both this and the
issue Koen found.
-b
---------------
Elizabeth Flanagan
Yocto Project
Release Engineer
next prev parent reply other threads:[~2011-05-28 23:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 22:13 [PATCH 0/1][v3] license.bbclass parsing changes rebased sans debug Elizabeth Flanagan
2011-05-27 22:36 ` Richard Purdie
2011-05-28 7:45 ` Koen Kooi
2011-05-28 9:16 ` Koen Kooi
2011-05-28 13:21 ` Elizabeth Flanagan
2011-05-28 13:41 ` Koen Kooi
2011-05-28 16:55 ` Khem Raj
2011-05-28 17:54 ` Elizabeth Flanagan
2011-05-28 20:57 ` Khem Raj
2011-05-28 23:31 ` Elizabeth Flanagan [this message]
2011-05-28 18:19 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE185BE.7000905@intel.com \
--to=elizabeth.flanagan@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.