All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prashanth Bhat <prashanth.bhat@manipal.net>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>
Subject: Re: Possible bug in sdio.c?
Date: Sun, 29 May 2011 20:47:48 +0530	[thread overview]
Message-ID: <4DE2639C.2090200@manipal.net> (raw)
In-Reply-To: <20110529141208.GC8360@rere.qmqm.pl>

On Sunday 29 May 2011 07:42 PM, Michał Mirosław wrote:
> On Sun, May 29, 2011 at 07:26:00AM +0530, Prashanth Bhat wrote:
>    
>> Hi Michał,
>> In mmc/core/sdio.c, routine mmc_enable_4bit_bus():
>>
>> I think:
>>
>>      if (card->type == MMC_TYPE_SDIO)
>>                return sdio_enable_wide(card);
>>
>> should really be:
>>
>>      if (card->type == MMC_TYPE_SDIO || card->type == MMC_TYPE_SD_COMBO )
>>                 return sdio_enable_wide(card);
>>
>> Otherwise, the SDIO component of the SD Combo card will not operate
>> in wide mode. What do you think?
>>
>> Perhaps a similar change is needed in the sdio_enable_hs() routine too.
>>      
> Hi,
>
> You sent similar problem report some time ago. I assumed you will follow
> on with a patch fixing mmc_card_sd() and friends (the functions you point
> out in this mail should use that).
>
> Best Regards,
> Michał Mirosław
>
>
>    
Thanks for the reply. Are there other places where this new function 
must be used? Is it only these 2 places?

Could you please clarify the formal process for including these changes 
into the build? I have made the previous changes in my private code tree 
only so far.

Thanks,
Prashanth

  reply	other threads:[~2011-05-29 15:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-29  1:56 Possible bug in sdio.c? Prashanth Bhat
2011-05-29 14:12 ` Michał Mirosław
2011-05-29 15:17   ` Prashanth Bhat [this message]
2011-05-29 15:24     ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE2639C.2090200@manipal.net \
    --to=prashanth.bhat@manipal.net \
    --cc=cjb@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.