All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Linux-kernel <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: unlink(nonexistent): EROFS or ENOENT?
Date: Sun, 29 May 2011 20:14:50 +0400	[thread overview]
Message-ID: <4DE270FA.6060702@msgid.tls.msk.ru> (raw)
In-Reply-To: <4DE26F97.9050607@msgid.tls.msk.ru>

29.05.2011 20:08, Michael Tokarev пишет:
> Hello.
> 
> Just noticed that at least on ext4, unlinking a
> non-existing file from a read-only filesystem
> results in EROFS instead of ENOENT.  I'd expect
> it return ENOENT - it is more logical, at least
> in my opinion.

http://pubs.opengroup.org/onlinepubs/009695399/functions/unlink.html
this case is quite clear:

 [EROFS]
    The directory entry to be unlinked
    is part of a read-only file system

Ie, the entry is a _part_ of a file system, so it should be
_existing_ entry to start with.

> For one, (readonly) NFS mount returns ENOENT in
> this case.
> 
> Thanks!

/mjt

  reply	other threads:[~2011-05-29 16:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-29 16:08 unlink(nonexistent): EROFS or ENOENT? Michael Tokarev
2011-05-29 16:14 ` Michael Tokarev [this message]
2011-06-06  3:39 ` Ted Ts'o
2011-06-06 17:13   ` Michael Tokarev
2011-06-06 17:18     ` Michael Tokarev
2011-06-06 19:55     ` Ted Ts'o
2011-06-06 20:37       ` [PATCH] vfs: make unlink() return ENOENT in preference to EROFS Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE270FA.6060702@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.