From: Kukjin Kim <kgene.kim@samsung.com>
To: Kyungmin Park <kmpark@infradead.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
lkml <linux-kernel@vger.kernel.org>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: gpio: gpio-exynos4 build fails in mainline
Date: Sun, 29 May 2011 19:50:37 -0700 [thread overview]
Message-ID: <4DE305FD.4040503@samsung.com> (raw)
In-Reply-To: <BANLkTinhXj51dzCnnXhxrCLeW1qQES6CvA@mail.gmail.com>
On 05/29/11 18:24, Kyungmin Park wrote:
> On Mon, May 30, 2011 at 12:44 AM, Randy Dunlap<rdunlap@xenotime.net> wrote:
>> On Sun, 29 May 2011 08:40:00 -0700 Randy Dunlap wrote:
(snip)
>>
>> drivers/gpio/gpio-s5pv210.c:17:11: error: unable to open 'plat/gpio-core.h'
>
Hi all,
Grrr, :(
> Hi,
>
> Right, now it's just moved from mach directories to drivers/gpio
> So it requires the proper depends on each ARCH_CPU.
>
Please add me in Cc on this.
> ---
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 5923976..655babf 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -88,24 +88,28 @@ config GPIO_IT8761E
>
> config GPIO_EXYNOS4
> bool "Samsung Exynos4 GPIO library support"
> + depends on CPU_EXYNOS4210
> default y if CPU_EXYNOS4210
> help
> Say yes here to support Samsung Exynos4 series SoCs GPIO library
Basically, GPIO_EXYNOS4 is used only for EXYNOS4(EXYNOS4210) and was
selected as a default on EXYNOS4 before moving into drivers/. I mean, do
we really need to select this manually in kernel configuration(like make
menuconfig)?
And I think, it's more reasonable that depends on ARCH_XXX not CPU_XXX.
Grant, how about following?
+config GPIO_EXYNOS4
+ bool
+ depends on ARCH_EXYNOS4
+ default y if CPU_EXYNOS4210
>
> config GPIO_PLAT_SAMSUNG
> bool "Samsung SoCs GPIO library support"
> + depends on SAMSUNG_GPIOLIB_4BIT
> default y if SAMSUNG_GPIOLIB_4BIT
> help
> Say yes here to support Samsung SoCs GPIO library
>
Same as above.
+config GPIO_PLAT_SAMSUNG
+ bool
+ depends on PLAT_SAMSUNG
+ default y if SAMSUNG_GPIOLIB_4BIT
> config GPIO_S5PC100
> bool "Samsung S5PC100 GPIO library support"
> + depends on CPU_S5PC100
> default y if CPU_S5PC100
> help
> Say yes here to support Samsung S5PC100 SoCs GPIO library
>
Same...
+config GPIO_S5PC100
+ bool
+ depends on ARCH_S5PC100
+ default y if CPU_S5PC100
> config GPIO_S5PV210
> bool "Samsung S5PV210/S5PC110 GPIO library support"
> + depends on CPU_S5PV210
> default y if CPU_S5PV210
> help
> Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
>
Same.
+config GPIO_S5PV210
+ bool
+ depends on ARCH_S5PV210
+ default y if CPU_S5PV210
One more, IMHO, would be better if they could not split like following.
As you know, 'PLAT_SAMSUNG' includes common GPIOlib for other Samsung SoCs.
config GPIO_PLAT_SAMSUNG
...
config GPIO_S5PC100
...
config GPIO_S5PV210
...
config GPIO_EXYNOS4
...
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2011-05-30 2:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-29 15:30 gpio: gpio-exynos4 build fails in mainline Randy Dunlap
2011-05-29 15:35 ` Randy Dunlap
2011-05-29 15:40 ` Randy Dunlap
2011-05-29 15:44 ` Randy Dunlap
2011-05-30 1:24 ` Kyungmin Park
2011-05-30 2:50 ` Kukjin Kim [this message]
2011-05-30 5:54 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE305FD.4040503@samsung.com \
--to=kgene.kim@samsung.com \
--cc=grant.likely@secretlab.ca \
--cc=kmpark@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.