From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU Date: Mon, 30 May 2011 12:45:37 +0200 Message-ID: <4DE37551.6060502@siemens.com> References: <4DE120BE.1010602@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Cc: kvm@vger.kernel.org, KaryJin@viatech.com.cn, mst@redhat.com, mtosatti@redhat.com, BrillyWu@viatech.com.cn, qemu-devel@nongnu.org, avi@redhat.com To: BrillyWu Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 2011-05-30 10:59, BrillyWu wrote: > From BrillyWu@viatech.com.cn > Hi, Jan > Thank you for you review and guide. > I have fixed the bugs and re-generated a clean patch which has > been checked. It can be compiled > without any error and work normally. > The patch v3 is here now. The above text can't be used as a commit log, so this needs to be fixed. Moreover, your patch still contains at least on style issues scripts/checkpatch.pl should have caught. Are you sure you ran it? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQzym-0003YE-R6 for qemu-devel@nongnu.org; Mon, 30 May 2011 06:45:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQzyl-0007sz-R5 for qemu-devel@nongnu.org; Mon, 30 May 2011 06:45:48 -0400 Received: from david.siemens.de ([192.35.17.14]:33993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQzyl-0007sl-BT for qemu-devel@nongnu.org; Mon, 30 May 2011 06:45:47 -0400 Message-ID: <4DE37551.6060502@siemens.com> Date: Mon, 30 May 2011 12:45:37 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4DE120BE.1010602@web.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BrillyWu Cc: kvm@vger.kernel.org, KaryJin@viatech.com.cn, mst@redhat.com, mtosatti@redhat.com, BrillyWu@viatech.com.cn, qemu-devel@nongnu.org, avi@redhat.com On 2011-05-30 10:59, BrillyWu wrote: > From BrillyWu@viatech.com.cn > Hi, Jan > Thank you for you review and guide. > I have fixed the bugs and re-generated a clean patch which has > been checked. It can be compiled > without any error and work normally. > The patch v3 is here now. The above text can't be used as a commit log, so this needs to be fixed. Moreover, your patch still contains at least on style issues scripts/checkpatch.pl should have caught. Are you sure you ran it? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux