From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: l-o <linux-omap@vger.kernel.org>
Cc: "Krishnamoorthy, Balaji T" <balajitk@ti.com>
Subject: V 3.0-rc1: [REPORT] OMAP MMC and CONSOLE Regression
Date: Mon, 30 May 2011 18:03:12 +0530 [thread overview]
Message-ID: <4DE38E88.1030402@ti.com> (raw)
While trying out V3.0-rc1, I noticed couple of regressions. Am
posting this in case anybody come across same issues.
1.OMAP MMC code keep throwing "Pbias Voltage is not same as LDO" error
continuously.
Balaji is planning post right fix for the same, but just
in case you get around this issue,
diff --git a/arch/arm/mach-omap2/hsmmc.c b/arch/arm/mach-omap2/hsmmc.c
index b2f30be..94ae400 100644
--- a/arch/arm/mach-omap2/hsmmc.c
+++ b/arch/arm/mach-omap2/hsmmc.c
@@ -145,6 +145,7 @@ static void omap4_hsmmc1_after_set_reg(struct device
*dev, int slot,
int power_on, int vdd)
{
u32 reg;
+ unsigned long timeout;
if (power_on) {
reg = omap4_ctrl_pad_readl(control_pbias_offset);
@@ -158,7 +159,14 @@ static void omap4_hsmmc1_after_set_reg(struct
device *dev, int slot,
OMAP4_USBC1_ICUSB_PWRDNZ_MASK);
omap4_ctrl_pad_writel(reg, control_pbias_offset);
/* 4 microsec delay for comparator to generate an error*/
- udelay(4);
+ timeout = jiffies + msecs_to_jiffies(500);
+ do {
+ reg = omap4_ctrl_pad_readl(control_pbias_offset);
+ if (!(reg & OMAP4_MMC1_PBIASLITE_VMODE_ERROR_MASK))
+ break;
+ mdelay(1);
+ } while (!time_after(jiffies, timeout));
+
reg = omap4_ctrl_pad_readl(control_pbias_offset);
if (reg & OMAP4_MMC1_PBIASLITE_VMODE_ERROR_MASK) {
pr_err("Pbias Voltage is not same as LDO\n");
2. can't open /dev/ttyO2: No such file or directory
This is not obvious console entry missing problem in FS.
Need to look at this further.
next reply other threads:[~2011-05-30 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 12:33 Santosh Shilimkar [this message]
2011-05-31 6:46 ` V 3.0-rc1: [REPORT] OMAP MMC and CONSOLE Regression T Krishnamoorthy, Balaji
2011-05-31 7:08 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE38E88.1030402@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=balajitk@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.