From: Guillaume Zajac <guillaume.zajac@linux.intel.com>
To: ofono@ofono.org
Subject: Re: [PATCH_v6 4/5] emulator: add request/release private network calls
Date: Mon, 30 May 2011 15:25:13 +0200 [thread overview]
Message-ID: <4DE39AB9.1020206@linux.intel.com> (raw)
In-Reply-To: <4DDCDDF7.2020401@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]
Hi Denis,
> I applied this patch, but have done heavy refactoring afterwards.
> Please review all my changes (~20 or so patches intermixed with yours)
> and make sure everything makes sense. I lightly tested this
> functionality with gsmdial and everything seems to be performing well.
>
> However, please test it really well yourself, use valgrind and try every
> exceptional condition you can think of.
>
I see you have changed the way PPP packets exchange start, that was what
was missing me.
Now we don't need anymore to copy into emulator structure the PN
settings as we can directly
pass the values to the PPP stack.
I also forgot to use set_write_done to trigger the resume GAtPPP/suspend
GAtChat.
It sounds ok to me.
I have tested it with Windows 7 DUN client and everything seems to work.
I have also found a way to test escape sequence from Windows 7 DUN client,
you just have to turn off your bluetooth adapter while you are connected
to oFono DUN server.
It will send +++ --> ATH0 and turn the adapter off.
Kind regards,
Guillaume
next prev parent reply other threads:[~2011-05-30 13:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 9:58 [PATCH_v6 0/5] Private network request to ConnMan Guillaume Zajac
2011-05-19 9:58 ` [PATCH_v6 1/5] gatppp: Add new contructor to use external fd Guillaume Zajac
2011-05-25 10:36 ` Denis Kenzior
2011-05-19 9:58 ` [PATCH_v6 2/5] private-network: add header into include and Makefile.am Guillaume Zajac
2011-05-25 10:38 ` Denis Kenzior
2011-05-19 9:58 ` [PATCH_v6 3/5] private-network: add request/release functions and new feature to Makefile.am Guillaume Zajac
2011-05-25 10:38 ` Denis Kenzior
2011-05-19 9:58 ` [PATCH_v6 4/5] emulator: add request/release private network calls Guillaume Zajac
2011-05-25 10:46 ` Denis Kenzior
2011-05-30 13:25 ` Guillaume Zajac [this message]
2011-05-19 9:58 ` [PATCH_v6 5/5] connman: add plugin in oFono to request/release private network Guillaume Zajac
2011-06-02 2:53 ` Denis Kenzior
-- strict thread matches above, loose matches on Subject: below --
2011-05-19 9:55 [PATCH_v6 0/5] *** SUBJECT HERE *** Guillaume Zajac
2011-05-19 9:55 ` [PATCH_v6 4/5] emulator: add request/release private network calls Guillaume Zajac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE39AB9.1020206@linux.intel.com \
--to=guillaume.zajac@linux.intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.