From: Mark Lord <kernel@teksavvy.com>
To: Bruce Stenning <b.stenning@indigovision.com>
Cc: Tejun Heo <htejun@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: sata_mv port lockup on hotplug (kernel 2.6.38.2)
Date: Mon, 30 May 2011 22:04:58 -0400 [thread overview]
Message-ID: <4DE44CCA.20608@teksavvy.com> (raw)
In-Reply-To: <C1438B59050E1B4C9482FF3266AD6BA32C7777DD92@gretna.indigovision.com>
On 11-05-30 09:07 AM, Bruce Stenning wrote:
>>> Mark, did you get a chance to clean up the sata_mv spinlock addition in
>>> mv_set_main_irq_mask?
>>
>> Not yet. I've been waiting to hear back from you as to
>> whether they visibly fix anything or not.
>
> Having now tested with Tejun's two patches and without the spinlock in
> mv_set_main_irq_mask for a reasonable time, the hotplug seems to be very
> reliable. So I think it's probably best to leave the spinlock out and
> continue to observe the behaviour with further testing.
Peachy. I'll have another look at some point -- I think I thought
the spinlock was still needed for ATAPI under some conditions.
Gotta look closer to make sure.
Thanks.
next prev parent reply other threads:[~2011-05-31 2:05 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 14:20 sata_mv port lockup on hotplug (kernel 2.6.38.2) Bruce Stenning
2011-04-06 14:57 ` Bruce Stenning
2011-04-06 20:52 ` Mark Lord
2011-04-08 12:43 ` Bruce Stenning
2011-04-08 12:43 ` Bruce Stenning
2011-04-09 0:48 ` Mark Lord
2011-04-12 10:30 ` Bruce Stenning
2011-04-12 10:30 ` Bruce Stenning
2011-04-12 14:07 ` Mark Lord
2011-04-12 14:55 ` Mark Lord
2011-04-23 0:56 ` Tejun Heo
2011-04-25 11:07 ` Bruce Stenning
2011-04-25 11:30 ` Tejun Heo
2011-04-26 18:27 ` Mark Lord
2011-04-25 14:54 ` Bruce Stenning
2011-04-25 16:22 ` Tejun Heo
2011-04-26 13:13 ` Bruce Stenning
2011-04-26 13:50 ` Tejun Heo
2011-04-26 15:41 ` Bruce Stenning
2011-04-26 15:52 ` Tejun Heo
2011-04-26 16:05 ` Bruce Stenning
2011-04-30 14:01 ` Tejun Heo
2011-05-17 15:30 ` Bruce Stenning
2011-05-25 9:41 ` Tejun Heo
2011-05-25 13:36 ` Bruce Stenning
2011-05-25 22:27 ` Mark Lord
2011-05-30 13:07 ` Bruce Stenning
2011-05-30 13:07 ` Bruce Stenning
2011-05-31 2:04 ` Mark Lord [this message]
2011-06-10 12:28 ` Mark Lord
2011-06-10 14:01 ` Tejun Heo
2011-06-10 17:32 ` Mark Lord
2011-06-10 17:39 ` Jeff Garzik
2011-06-10 20:49 ` Mark Lord
2011-06-10 21:20 ` Jeff Garzik
2011-06-11 12:19 ` Tejun Heo
2011-06-12 17:10 ` Mark Lord
2011-06-13 10:48 ` Tejun Heo
2011-08-29 15:49 ` Bruce Stenning
2011-09-02 1:13 ` Tejun Heo
2011-09-02 16:22 ` Bruce Stenning
2011-09-06 3:45 ` Tejun Heo
2011-09-06 12:19 ` Bruce Stenning
2011-09-06 16:33 ` Tejun Heo
2011-09-06 16:42 ` Tejun Heo
2011-09-07 12:09 ` Bruce Stenning
2011-09-08 1:16 ` Tejun Heo
2011-09-06 12:26 ` Bruce Stenning
2011-09-06 14:40 ` Bruce Stenning
2011-09-06 15:22 ` Bruce Stenning
2011-04-26 18:37 ` Mark Lord
2011-04-13 15:10 ` Mark Lord
2011-04-13 16:13 ` Bruce Stenning
2011-04-13 16:13 ` Bruce Stenning
2011-04-14 16:50 ` Bruce Stenning
2011-04-14 16:50 ` Bruce Stenning
2011-04-15 0:28 ` Mark Lord
2011-04-15 13:21 ` Bruce Stenning
2011-04-15 13:21 ` Bruce Stenning
2011-04-15 15:36 ` Mark Lord
2011-04-18 10:30 ` Bruce Stenning
2011-04-18 10:30 ` Bruce Stenning
2011-04-23 0:56 ` Tejun Heo
2011-04-15 3:15 ` Mikael Abrahamsson
2011-04-15 3:32 ` Mark Lord
2011-04-15 7:43 ` Mikael Abrahamsson
2011-04-15 12:35 ` Mark Lord
2011-04-15 14:04 ` Mikael Abrahamsson
2011-04-15 15:30 ` Mark Lord
2011-04-06 21:00 ` Alejandro Riveira Fernández
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE44CCA.20608@teksavvy.com \
--to=kernel@teksavvy.com \
--cc=b.stenning@indigovision.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.