Re: [netfilter-core] Cannot unload nf_conntrack

[Menyhart Zoltan <Zoltan.Menyhart@Bull.net>]

Pablo Neira Ayuso wrote:

> Sorry, no patch for 2.6.32. But I appreciate if you can add that chuck
> by yourself, it's quite easy:
>
>   785        if (l4proto->error != NULL) {
>   786                ret = l4proto->error(net, skb, dataoff,&ctinfo, pf, hooknum);
>   787                if (ret<= 0) {
>   788                        NF_CT_STAT_INC_ATOMIC(net, error);
>   789                        NF_CT_STAT_INC_ATOMIC(net, invalid);
>   790                        return -ret;
>   791                }
>
> add it here.
>
>   792        }
>
> And test it, of course.

I *did* try it before I asked for the patch for 2.6.32.
My problem is: there is no "out:" branch in the 2.6.32.

out:
         if (tmpl) {
                 /* Special case: we have to repeat this hook, assign the
                  * template again to this packet. We assume that this packet
                  * has no conntrack assigned. This is used by nf_ct_tcp. */
                 if (ret == NF_REPEAT)
                         skb->nfct = (struct nf_conntrack *)tmpl;
                 else
                         nf_ct_put(tmpl);
         }

There is no "struct nf_conn *tmpl;" either.
What shall I do instead of "goto out;"?

Thanks,

Zoltan