From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRLT9-0001Tk-AQ for qemu-devel@nongnu.org; Tue, 31 May 2011 05:42:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRLT8-00046a-I4 for qemu-devel@nongnu.org; Tue, 31 May 2011 05:42:35 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:45341) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRLT8-00046P-9h for qemu-devel@nongnu.org; Tue, 31 May 2011 05:42:34 -0400 Message-ID: <4DE4B808.4030104@msgid.tls.msk.ru> Date: Tue, 31 May 2011 13:42:32 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1306834530-12763-1-git-send-email-hdegoede@redhat.com> <1306834530-12763-15-git-send-email-hdegoede@redhat.com> In-Reply-To: <1306834530-12763-15-git-send-email-hdegoede@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: qemu-devel@nongnu.org 31.05.2011 13:35, Hans de Goede wrote: > --- > hw/usb-bus.c | 23 ++++++++++++----------- > hw/usb-msd.c | 5 +++-- > usb-linux.c | 6 +++++- > 3 files changed, 20 insertions(+), 14 deletions(-) > > diff --git a/hw/usb-bus.c b/hw/usb-bus.c > index 0a49921..2ae2678 100644 > --- a/hw/usb-bus.c > +++ b/hw/usb-bus.c > if (dev->attached) { > - fprintf(stderr, "Warning: tried to attach usb device %s twice\n", > + fprintf(stderr, "Error: tried to attach usb device %s twice\n", > dev->product_desc); qemu_error() maybe, while we're at it? Here and in a few other places. Thanks! /mjt