From: Avi Kivity <avi@redhat.com>
To: "Yang, Wei Y" <wei.y.yang@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v6 3/4] Mask function7 ebx against host capability word9
Date: Wed, 01 Jun 2011 11:57:41 +0300 [thread overview]
Message-ID: <4DE5FF05.9030501@redhat.com> (raw)
In-Reply-To: <5D8008F58939784290FAB48F5497519844E9278572@shsmsx502.ccr.corp.intel.com>
On 05/30/2011 06:17 PM, Yang, Wei Y wrote:
> This patch masks CPUID leaf 7 ebx against host capability word9.
> @@ -2404,6 +2408,15 @@ static void do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function,
> }
> break;
> }
> + case 7: {
> + /* Mask ebx against host capbability word 9 */
> + if (index == 0) {
> + entry->ebx&= kvm_supported_word9_x86_features;
> + cpuid_mask(&entry->edx, 9);
> + }
> + break;
> + }
> + /* function 0xb has additional index. */
I see that function 7 also depends on ecx, so it should set
KVM_CPUID_FLAG_SIGNIFCANT_INDEX.
We should mask off ecx != 0 and all the reserved words, since we don't
support the features in them.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-06-01 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 15:17 [PATCH v6 3/4] Mask function7 ebx against host capability word9 Yang, Wei Y
2011-06-01 8:57 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE5FF05.9030501@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=wei.y.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.