From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/2] Kill decode_cache Date: Wed, 01 Jun 2011 15:56:11 +0300 Message-ID: <4DE636EB.3040608@redhat.com> References: <1306931665-26507-1-git-send-email-avi@redhat.com> <20110601124718.GF491@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7458 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751458Ab1FAM4W (ORCPT ); Wed, 1 Jun 2011 08:56:22 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p51CuMV0031752 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 1 Jun 2011 08:56:22 -0400 In-Reply-To: <20110601124718.GF491@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/01/2011 03:47 PM, Gleb Natapov wrote: > On Wed, Jun 01, 2011 at 03:34:23PM +0300, Avi Kivity wrote: > > This mostly mindless patchset folds decode_cache into its enclosing struct, > > x86_emulate_context. The point is to remove tons of pointless > > > > struct decode_cache *c =&ctxt->decode; > > > > lines from the code, which contribute absolutely nothing. > > > Didn't we plan some day to have a cache of decoded instructions to skip > decoding stage? Not all the fields currently in decode_cache belong > there of course (regs, io_read, mem_read). > I remember something vaguely. But it will be a much smaller subset of decode_cache than what we have here. -- error compiling committee.c: too many arguments to function