All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors
Date: Wed, 01 Jun 2011 16:42:41 +0200	[thread overview]
Message-ID: <4DE64FE1.2000104@redhat.com> (raw)
In-Reply-To: <4DE63599.2060803@redhat.com>

Hi,

On 06/01/2011 02:50 PM, Gerd Hoffmann wrote:
> Hi,
>
>> I'll wait a bit for more feedback and then change
>> [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors
>
> I'll wait for new revisions of patches 12+14 then.

I already fixed this yeterday, I opted to leave patch 12 unmodified and
replace all fprintf(stderr, ... calls with error_report calls in one go
in a new patch 14.

You can find the new version here:
http://cgit.freedesktop.org/~jwrdegoede/qemu/commit/?h=usb-patches&id=3c0be7730ff74a5cdac6aa100179b15c9392ab5f

Let me know if you'd rather have me resend 12 + 14 to the list.

Regards,

Hans

  reply	other threads:[~2011-06-01 14:42 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-31  9:35 [Qemu-devel] [PATCH 00/14] usb: various usb fixes Hans de Goede
2011-05-31  9:35 ` [Qemu-devel] [PATCH 01/14] usb-linux: Set usb_auto_timer to NULL after deleting it Hans de Goede
2011-06-01 10:48   ` Gerd Hoffmann
2011-06-01 14:24     ` Hans de Goede
2011-05-31  9:35 ` [Qemu-devel] [PATCH 02/14] usb-linux: Get speed from sysfs rather then from the connectinfo ioctl Hans de Goede
2011-06-01 11:25   ` Gerd Hoffmann
2011-05-31  9:35 ` [Qemu-devel] [PATCH 03/14] usb-linux: Teach about super speed Hans de Goede
2011-06-01 11:28   ` Gerd Hoffmann
2011-05-31  9:35 ` [Qemu-devel] [PATCH 04/14] usb-linux: Don't do perror when errno is not set Hans de Goede
2011-06-01 11:29   ` Gerd Hoffmann
2011-06-01 11:43   ` Gerd Hoffmann
2011-05-31  9:35 ` [Qemu-devel] [PATCH 05/14] usb-linux: Don't call usb_host_close when usb_host_open fails Hans de Goede
2011-06-01 12:22   ` Gerd Hoffmann
2011-06-01 14:33     ` Hans de Goede
2011-05-31  9:35 ` [Qemu-devel] [PATCH 06/14] usb-linux: Ensure devep != 0 Hans de Goede
2011-06-01 12:24   ` Gerd Hoffmann
2011-05-31  9:35 ` [Qemu-devel] [PATCH 07/14] usb-linux: If opening a device fails remove it from our filter list Hans de Goede
2011-06-01 12:32   ` Gerd Hoffmann
2011-06-01 14:37     ` Hans de Goede
2011-06-06 10:24       ` Gerd Hoffmann
2011-05-31  9:35 ` [Qemu-devel] [PATCH 08/14] usb-linux: Don't try to open the same device twice Hans de Goede
2011-06-01 12:35   ` Gerd Hoffmann
2011-05-31  9:35 ` [Qemu-devel] [PATCH 09/14] usb-linux: Don't declare a usbdevice_name Hans de Goede
2011-06-01 12:44   ` Gerd Hoffmann
2011-06-01 14:38     ` Hans de Goede
2011-05-31  9:35 ` [Qemu-devel] [PATCH 10/14] usb-linux: Enlarge buffer for descriptors to 8192 bytes Hans de Goede
2011-06-01 12:44   ` Gerd Hoffmann
2011-05-31  9:35 ` [Qemu-devel] [PATCH 11/14] usb-bus: Add knowledge of USB_SPEED_SUPER to usb_speed helper Hans de Goede
2011-06-01 12:47   ` Gerd Hoffmann
2011-05-31  9:35 ` [Qemu-devel] [PATCH 12/14] usb-bus: Don't allow attaching a device to a bus with no free ports Hans de Goede
2011-05-31  9:35 ` [Qemu-devel] [PATCH 13/14] usb-bus: Don't detach non attached devices on device exit Hans de Goede
2011-06-01 12:51   ` Gerd Hoffmann
2011-05-31  9:35 ` [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors Hans de Goede
2011-05-31  9:42   ` Michael Tokarev
2011-05-31  9:51     ` Hans de Goede
2011-05-31  9:56       ` Kevin Wolf
2011-05-31 10:05         ` Hans de Goede
2011-05-31 10:12           ` Kevin Wolf
2011-05-31 10:13             ` Hans de Goede
2011-06-01 12:50               ` Gerd Hoffmann
2011-06-01 14:42                 ` Hans de Goede [this message]
2011-06-06 10:27                   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE64FE1.2000104@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.