From: Tushar Behera <tushar.behera@linaro.org>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, linaro-dev@lists.linaro.org,
kgene.kim@samsung.com, nicolas.pitre@linaro.org,
patches@linaro.org, samsung@lists.linaro.org,
m.szyprowski@samsung.com
Subject: Re: [PATCH V2] ARM: S5P: Fix compilation error for exynos4_defconfig
Date: Fri, 03 Jun 2011 14:14:32 +0530 [thread overview]
Message-ID: <4DE89EF0.5090707@linaro.org> (raw)
In-Reply-To: <4DE8924B.5010003@samsung.com>
Hi,
On Friday 03 June 2011 01:20 PM, Joonyoung Shim wrote:
> On 2011-06-03 오후 4:04, Tushar Behera wrote:
>> Added Kconfig entry for setup-usb-phy.c on which EHCI support is
>> dependent on.
>>
>> Following the naming convention of other setup files, we have following
>> renaming.
>> usb-phy.c ==> setup-usb-phy.c
>>
>> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
>> ---
>> arch/arm/mach-exynos4/Kconfig | 6 ++++++
>> arch/arm/mach-exynos4/Makefile | 2 +-
>> .../mach-exynos4/{usb-phy.c => setup-usb-phy.c} | 0
>> 3 files changed, 7 insertions(+), 1 deletions(-)
>> rename arch/arm/mach-exynos4/{usb-phy.c => setup-usb-phy.c} (100%)
>>
>
> There is one white space but
>
> Acked-by: Joonyoung Shim <jy0922.shim@samsung.com>
>
>> diff --git a/arch/arm/mach-exynos4/Kconfig
>> b/arch/arm/mach-exynos4/Kconfig
>> index b92c1e5..a45a022 100644
>> --- a/arch/arm/mach-exynos4/Kconfig
>> +++ b/arch/arm/mach-exynos4/Kconfig
>> @@ -91,6 +91,11 @@ config EXYNOS4_SETUP_FIMC
>> help
>> Common setup code for the camera interfaces.
>>
>> +config EXYNOS4_SETUP_USB_PHY
>> + bool
>> + help
>> + Common setup code for USB PHY controller
>
> White space.
The space was added so that it is formatted in the same way as other
Kconfig entries.
>
>> +
>> # machine support
>>
>> menu "EXYNOS4 Machines"
>> @@ -176,6 +181,7 @@ config MACH_NURI
>> select EXYNOS4_SETUP_I2C3
>> select EXYNOS4_SETUP_I2C5
>> select EXYNOS4_SETUP_SDHCI
>> + select EXYNOS4_SETUP_USB_PHY
>> select SAMSUNG_DEV_PWM
>> help
>> Machine support for Samsung Mobile NURI Board.
>> diff --git a/arch/arm/mach-exynos4/Makefile
>> b/arch/arm/mach-exynos4/Makefile
>> index a9bb94f..60fe5ec 100644
>> --- a/arch/arm/mach-exynos4/Makefile
>> +++ b/arch/arm/mach-exynos4/Makefile
>> @@ -56,4 +56,4 @@ obj-$(CONFIG_EXYNOS4_SETUP_KEYPAD) += setup-keypad.o
>> obj-$(CONFIG_EXYNOS4_SETUP_SDHCI) += setup-sdhci.o
>> obj-$(CONFIG_EXYNOS4_SETUP_SDHCI_GPIO) += setup-sdhci-gpio.o
>>
>> -obj-$(CONFIG_USB_SUPPORT) += usb-phy.o
>> +obj-$(CONFIG_EXYNOS4_SETUP_USB_PHY) += setup-usb-phy.o
>> diff --git a/arch/arm/mach-exynos4/usb-phy.c
>> b/arch/arm/mach-exynos4/setup-usb-phy.c
>> similarity index 100%
>> rename from arch/arm/mach-exynos4/usb-phy.c
>> rename to arch/arm/mach-exynos4/setup-usb-phy.c
--
Tushar Behera
next prev parent reply other threads:[~2011-06-03 8:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 7:04 [PATCH V2] ARM: S5P: Fix compilation error for exynos4_defconfig Tushar Behera
2011-06-03 7:50 ` Joonyoung Shim
2011-06-03 8:44 ` Tushar Behera [this message]
2011-06-03 8:58 ` Joonyoung Shim
2011-06-03 9:24 ` Tushar Behera
2011-06-03 11:51 ` Thomas Abraham
2011-06-03 13:25 ` Marek Szyprowski
2011-06-03 22:32 ` Kukjin Kim
-- strict thread matches above, loose matches on Subject: below --
2011-06-03 8:03 JinGoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE89EF0.5090707@linaro.org \
--to=tushar.behera@linaro.org \
--cc=jy0922.shim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=nicolas.pitre@linaro.org \
--cc=patches@linaro.org \
--cc=samsung@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.