Re: [PATCH] wxbase_2.8.9: fix includepath for SDL dependency

[Matteo Facchinetti <matteo.facchinetti@sirius-es.it>]

On 06/01/2011 06:11 PM, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 01-06-11 15:29, Matteo Facchinetti wrote:
>> From: Matteo Facchinetti<engineering@sirius-es.it>
>>
>> Compile task fail with error:
>> | CROSS COMPILE Badness: /usr/include in INCLUDEPATH: /usr/include/SDL
>> | cc1plus: internal compiler error: in add_path, at c-incpath.c:425
>>
>> Fix it forcing right path in configuration.
>>
>>
>> Signed-off-by: Matteo Facchinetti<engineering@sirius-es.it>
>> ---
>>   recipes/wxwidgets/wxbase_2.8.9.bb |    3 ++-
>>   1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/recipes/wxwidgets/wxbase_2.8.9.bb b/recipes/wxwidgets/wxbase_2.8.9.bb
>> index fb18710..7d593ad 100644
>> --- a/recipes/wxwidgets/wxbase_2.8.9.bb
>> +++ b/recipes/wxwidgets/wxbase_2.8.9.bb
>> @@ -9,7 +9,8 @@ SRC_URI += "file://Makefile.in.patch"
>>   EXTRA_OECONF = " --disable-gui \
>>                    --enable-largefile \
>>                    --enable-gpe \
>> -                 --without-subdirs"
>> +                 --without-subdirs \
>> +                 --with-sdl-prefix=${D}"
> Usually that means you end with with references to $WORKDIR in the
> target binaries, is this one safe?
>
mmmm...
While checking about it I have discovered a mistake:

In this case "--with-sdl-prefix" is used only for the basepath where 
sdl-config script is located.

Configure script set:
SDL_CONFIG=$sdl_prefix/bin/sdl-config

Then, if sdl-config is found (located in that position), it says to 
wxbase the right path where SDL library is located.
Binaries seems to be created exactly like the other libraries.

For this reason the only right way I've found is to use:
--with-sdl-prefix="${STAGING_BINDIR_CROSS}/.."

Is it goes well?

if yes I prepare v2 of this patch...