All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>, <alan@lxorguk.ukuu.org.uk>,
	<linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>
Subject: Re: [PATCH] lib: introduce strdup_from_user
Date: Fri, 3 Jun 2011 13:57:38 -0500	[thread overview]
Message-ID: <4DE92EA2.60705@freescale.com> (raw)
In-Reply-To: <20110603135303.0800e4a7@schlenkerla.am.freescale.net>

Scott Wood wrote:
> Why does it matter, as long as it doesn't hurt the kernel if userspace
> plays games (i.e. take care of the NUL termination), and it's not a
> performance problem?

Ok, I don't know why I didn't notice this earlier, but this function already
exists in the kernel.  It's called strndup_user().

So I'd like to rescind this patch, please.

Note that strndup_user() has the double-access problem.

-- 
Timur Tabi
Linux kernel developer at Freescale


  reply	other threads:[~2011-06-03 18:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-03 16:45 [PATCH] lib: introduce strdup_from_user Timur Tabi
2011-06-03 17:45 ` Alexey Dobriyan
2011-06-03 18:22   ` Timur Tabi
2011-06-03 18:26     ` Alexey Dobriyan
2011-06-03 18:34       ` Timur Tabi
2011-06-03 18:39         ` Alexey Dobriyan
2011-06-03 18:41           ` Timur Tabi
2011-06-03 18:47             ` Alexey Dobriyan
2011-06-03 18:54               ` Timur Tabi
2011-06-03 18:53           ` Scott Wood
2011-06-03 18:57             ` Timur Tabi [this message]
2011-06-03 19:12             ` Alexey Dobriyan
2011-06-03 19:31               ` Scott Wood
2011-06-03 22:41               ` Al Viro
2011-06-03 18:37       ` Scott Wood
2011-06-03 21:58   ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE92EA2.60705@freescale.com \
    --to=timur@freescale.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.