From: Avi Kivity <avi@redhat.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH v1 5/5] KVM: Expose a version 1 architectural PMU to guests
Date: Sun, 05 Jun 2011 11:12:58 +0300 [thread overview]
Message-ID: <4DEB3A8A.9060401@redhat.com> (raw)
In-Reply-To: <1307112113.2353.3391.camel@twins>
On 06/03/2011 05:41 PM, Peter Zijlstra wrote:
> On Wed, 2011-05-11 at 11:55 -0400, Avi Kivity wrote:
> > +static u64 read_gp_pmc(struct kvm_pmu *pmu, struct kvm_pmc *pmc)
> > +{
> > + u64 counter, enabled, running;
> > +
> > + counter = pmc->counter;
> > +
> > + if (pmc->perf_event)
> > + counter += perf_event_read_value(pmc->perf_event,
> > +&enabled,&running);
> > +
> > + /* FIXME: Scaling needed? */
>
> Yeah, either that or use attr.pinned = 1, doing the latter will result
> in an error when the PMU is overloaded though.
So what's the scale factor? enabled / running?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-06-05 8:13 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 15:55 [PATCH v1 0/5] KVM in-guest performance monitoring Avi Kivity
2011-05-11 15:55 ` [PATCH v1 1/5] perf: add context parameter to perf_event overflow handler Avi Kivity
2011-06-03 14:41 ` Peter Zijlstra
2011-06-05 8:07 ` Avi Kivity
2011-05-11 15:55 ` [PATCH v1 2/5] x86, perf: add constraints for architectural PMU v1 Avi Kivity
2011-05-11 15:55 ` [PATCH v1 3/5] perf: export perf_event_refresh() to modules Avi Kivity
2011-05-11 15:55 ` [PATCH v1 4/5] KVM: Expose kvm_lapic_local_deliver() Avi Kivity
2011-05-11 15:55 ` [PATCH v1 5/5] KVM: Expose a version 1 architectural PMU to guests Avi Kivity
2011-05-17 19:41 ` Ingo Molnar
2011-05-18 9:03 ` Avi Kivity
2011-05-18 11:07 ` Ingo Molnar
2011-05-18 11:29 ` Peter Zijlstra
2011-05-18 11:57 ` Ingo Molnar
2011-05-18 11:32 ` Peter Zijlstra
2011-05-18 11:37 ` Avi Kivity
2011-05-18 12:35 ` Peter Zijlstra
2011-05-18 12:49 ` Avi Kivity
2011-06-03 14:41 ` Peter Zijlstra
2011-06-05 8:12 ` Avi Kivity
2011-06-03 14:41 ` Peter Zijlstra
2011-06-05 8:12 ` Avi Kivity [this message]
2011-05-12 9:33 ` [PATCH v1 0/5] KVM in-guest performance monitoring Joerg Roedel
2011-05-12 9:47 ` Jan Kiszka
2011-05-12 9:53 ` Avi Kivity
2011-05-12 13:11 ` Joerg Roedel
2011-05-12 13:23 ` Jan Kiszka
2011-05-12 13:43 ` Joerg Roedel
2011-05-12 13:31 ` Avi Kivity
2011-05-12 14:24 ` Joerg Roedel
2011-05-12 14:37 ` Avi Kivity
2011-05-12 14:45 ` Avi Kivity
2011-05-13 12:34 ` Joerg Roedel
2011-05-12 9:51 ` Avi Kivity
2011-05-12 13:06 ` Joerg Roedel
2011-05-12 13:38 ` Avi Kivity
2011-05-12 14:29 ` Joerg Roedel
2011-05-17 9:52 ` Avi Kivity
2011-06-01 9:45 ` Avi Kivity
2011-06-01 10:26 ` Peter Zijlstra
2011-06-01 11:26 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEB3A8A.9060401@redhat.com \
--to=avi@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.