From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Graunke Subject: Re: [PATCH 2/2] dri: Add support for DRI2BufferStencil and DRI2BufferHiz Date: Sun, 05 Jun 2011 01:56:13 -0700 Message-ID: <4DEB44AD.7070903@whitecape.org> References: <1307232391-26973-1-git-send-email-chad@chad-versace.us> <1307232391-26973-3-git-send-email-chad@chad-versace.us> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from homiemail-a37.g.dreamhost.com (caiajhbdcagg.dreamhost.com [208.97.132.66]) by gabe.freedesktop.org (Postfix) with ESMTP id CB3B49E832 for ; Sun, 5 Jun 2011 01:56:08 -0700 (PDT) In-Reply-To: <1307232391-26973-3-git-send-email-chad@chad-versace.us> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chad Versace Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 06/04/2011 05:06 PM, Chad Versace wrote: > Before this commit, if a client were to request a stencil or hiz buffer, then > I830DRI2CreateBuffer() allocated and returned an X-tiled buffer by > accident. (DRI2BufferStencil and DRI2BufferHiz were unintentionally caught > by the default case of a switch statement.) > > Now, I830DRI2CreateBuffer() correctly returns a Y-tiled buffer and handles > the stencil buffer as a special case due its quirky pitch requirements. > > This shouldn't break older Mesa versions, because they never query (via > DRI2GetBuffersWithFormat) for the drawable's DRI2BufferStencil. > > Signed-off-by: Chad Versace > --- > src/intel_dri.c | 30 ++++++++++++++++++++++++++---- > 1 files changed, 26 insertions(+), 4 deletions(-) This looks good to me, though I'm not too familiar with the DDX code. Reviewed-by: Kenneth Graunke