From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49736)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nwhitehorn@freebsd.org>) id 1QTDvV-0004EN-I7
	for qemu-devel@nongnu.org; Sun, 05 Jun 2011 10:03:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nwhitehorn@freebsd.org>) id 1QTDvT-0002Lp-GF
	for qemu-devel@nongnu.org; Sun, 05 Jun 2011 10:03:37 -0400
Received: from agogare.doit.wisc.edu ([144.92.197.211]:63947)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nwhitehorn@freebsd.org>) id 1QTDvT-0002LT-6K
	for qemu-devel@nongnu.org; Sun, 05 Jun 2011 10:03:35 -0400
Received: from avs-daemon.smtpauth2.wiscmail.wisc.edu by
	smtpauth2.wiscmail.wisc.edu
	(Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30
	2009)) id <0LMB00300LPXZU00@smtpauth2.wiscmail.wisc.edu> for
	qemu-devel@nongnu.org; Sun, 05 Jun 2011 09:03:33 -0500 (CDT)
Date: Sun, 05 Jun 2011 09:03:31 -0500
From: Nathan Whitehorn <nwhitehorn@freebsd.org>
In-reply-to: <69ABB818-A4BC-4E2F-ABEC-B4A4804D7B8A@web.de>
Message-id: <4DEB8CB3.8000400@freebsd.org>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: QUOTED-PRINTABLE
References: <4DE501D2.7060505@freebsd.org>
	<69ABB818-A4BC-4E2F-ABEC-B4A4804D7B8A@web.de>
Subject: Re: [Qemu-devel] [PATCH] Fix build on FreeBSD
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
Cc: Alexandre Raymond <cerbere@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>

On 06/02/11 10:01, Andreas F=E4rber wrote:
> Am 31.05.2011 um 16:57 schrieb Nathan Whitehorn:
>
>> Add some includes required to build qemu on FreeBSD.
>
> Missing Sob.

Oops, I'll resubmit.

>> ---
>> bsd-user/syscall.c |    2 ++
>> iohandler.c        |    1 +
>> os-posix.c         |    4 ++++
>> 3 files changed, 7 insertions(+), 0 deletions(-)
> [...]
>> diff --git a/iohandler.c b/iohandler.c
>> index 2b82421..7266aca 100644
>> --- a/iohandler.c
>> +++ b/iohandler.c
>> @@ -29,6 +29,7 @@
>>
>> #ifndef _WIN32
>> #include <sys/wait.h>
>> +#include <signal.h>
>> #endif
>>
>> typedef struct IOHandlerRecord {
>
> This is independent of the other BSD issues (that I cannot judge) a=
nd=20
> affects Darwin and Haiku as well. Did you check that with your patc=
h=20
> Win32 does not need the header?
>
> Alexandre (cc'ed) posted a slightly different patch, adding it in=
=20
> qemu-common.h instead.

Ah, that's fine then. I have no idea about Win32, I just know it won'=
t=20
compile on FreeBSD without it, since it hasn't been included yet as a=
=20
side effect.
-Nathan