All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vipin Kumar <vipin.kumar@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: designware: fix unused warning when CONFIG_DW_AUTONEG is enabled
Date: Mon, 6 Jun 2011 09:51:12 +0530	[thread overview]
Message-ID: <4DEC55B8.4060606@st.com> (raw)
In-Reply-To: <1307027978-13418-1-git-send-email-vapier@gentoo.org>

On 6/2/2011 8:49 PM, Mike Frysinger wrote:
> The ctrl variable is only used when autoneg support is disabled, so only
> declare it under those conditions to avoid an unused variable warning.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  drivers/net/designware.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/designware.c b/drivers/net/designware.c
> index 3f5eeb7..96f20d1 100644
> --- a/drivers/net/designware.c
> +++ b/drivers/net/designware.c
> @@ -368,11 +368,13 @@ static int configure_phy(struct eth_device *dev)
>  {
>  	struct dw_eth_dev *priv = dev->priv;
>  	int phy_addr;
> -	u16 bmcr, ctrl;
> +	u16 bmcr;
>  #if defined(CONFIG_DW_AUTONEG)
>  	u16 bmsr;
>  	u32 timeout;
>  	u16 anlpar, btsr;
> +#else
> +	u16 ctrl;
>  #endif
>  
>  #if defined(CONFIG_DW_SEARCH_PHY)

Reviewed-by: Vipin Kumar <vipin.kumar@st.com>

Regards
Vipin

  parent reply	other threads:[~2011-06-06  4:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 15:19 [U-Boot] [PATCH] net: designware: fix unused warning when CONFIG_DW_AUTONEG is enabled Mike Frysinger
2011-06-02 15:19 ` [U-Boot] [PATCH] net: designware: fix uninitialized phy_addr usage Mike Frysinger
2011-06-06  4:21   ` Vipin Kumar
2011-07-25 20:21   ` Wolfgang Denk
2011-06-06  4:21 ` Vipin Kumar [this message]
2011-07-25 20:20 ` [U-Boot] [PATCH] net: designware: fix unused warning when CONFIG_DW_AUTONEG is enabled Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DEC55B8.4060606@st.com \
    --to=vipin.kumar@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.