From: Avi Kivity <avi@redhat.com>
To: Mike Waychison <mikew@google.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
digitaleric@google.com, san@google.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Subject: Re: [PATCH] KVM: Initialize kvm before registering the mmu notifier
Date: Mon, 06 Jun 2011 11:28:04 +0300 [thread overview]
Message-ID: <4DEC8F94.8010602@redhat.com> (raw)
In-Reply-To: <1307131493-553-1-git-send-email-mikew@google.com>
On 06/03/2011 11:04 PM, Mike Waychison wrote:
> It doesn't make sense to ever see a half-initialized kvm structure on
> mmu notifier callbacks. Previously, 85722cda changed the ordering to
> ensure that the mmu_lock was initialized before mmu notifier
> registration, but there is still a race where the mmu notifier could
> come in and try accessing other portions of struct kvm before they are
> intialized.
>
> Solve this by moving the mmu notifier registration to occur after the
> structure is completely initialized.
Thanks, applied, and queued for 3.0.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-06-06 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 20:04 [PATCH] KVM: Initialize kvm before registering the mmu notifier Mike Waychison
2011-06-06 8:28 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEC8F94.8010602@redhat.com \
--to=avi@redhat.com \
--cc=digitaleric@google.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=mtosatti@redhat.com \
--cc=san@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.