diff for duplicates of <4DECD2D7.6030207@ti.com> diff --git a/a/1.txt b/N1/1.txt index 6995ab8..c25dbe8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -33,7 +33,7 @@ On 6/6/2011 3:01 PM, Valkeinen, Tomi wrote: >>>>> >>>>> Yes, the counter. I don't think >>>>> ->>>>> if (dispc.runtime_count++ = 0) +>>>>> if (dispc.runtime_count++ == 0) >>>>> >>>>> is thread safe. >>>> @@ -45,7 +45,7 @@ On 6/6/2011 3:01 PM, Valkeinen, Tomi wrote: >>> do "put" before the whole "get" has finished. Otherwise we could end up, >>> for example, disabling a clock before enabling it. >>> ->>>>>>> + if (dispc.runtime_count++ = 0) { +>>>>>>> + if (dispc.runtime_count++ == 0) { >>>>>> >>>>>> You shouldn't need your own use-counting here. The runtime PM core is >>>>>> already doing usage counting. diff --git a/a/content_digest b/N1/content_digest index 9c7fa35..a5512b7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -8,7 +8,7 @@ "ref\01307365290.1910.39.camel@deskari\0" "From\0Cousson, Benoit <b-cousson@ti.com>\0" "Subject\0Re: [PATCH 19/27] OMAP: DSS2: Use PM runtime & HWMOD support\0" - "Date\0Mon, 06 Jun 2011 13:15:03 +0000\0" + "Date\0Mon, 6 Jun 2011 15:15:03 +0200\0" "To\0Valkeinen" " Tomi <tomi.valkeinen@ti.com>\0" "Cc\0Hilman" @@ -53,7 +53,7 @@ ">>>>>\n" ">>>>> Yes, the counter. I don't think\n" ">>>>>\n" - ">>>>> if (dispc.runtime_count++ = 0)\n" + ">>>>> if (dispc.runtime_count++ == 0)\n" ">>>>>\n" ">>>>> is thread safe.\n" ">>>>\n" @@ -65,7 +65,7 @@ ">>> do \"put\" before the whole \"get\" has finished. Otherwise we could end up,\n" ">>> for example, disabling a clock before enabling it.\n" ">>>\n" - ">>>>>>> +\tif (dispc.runtime_count++ = 0) {\n" + ">>>>>>> +\tif (dispc.runtime_count++ == 0) {\n" ">>>>>>\n" ">>>>>> You shouldn't need your own use-counting here. The runtime PM core is\n" ">>>>>> already doing usage counting.\n" @@ -146,4 +146,4 @@ "Regards,\n" Benoit -17c08f8d2072c88c5d71757248e4576d8c446a1592f5b0759b3d519d9e6fad5d +b6e90f3645d66c44bfc81c85d00faadee08bbc40539d7b16f52a7d22e52b0b5b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.