From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lmLogOpen() broken failure exit
Date: Mon, 06 Jun 2011 08:42:12 -0500 [thread overview]
Message-ID: <4DECD934.6000004@oracle.com> (raw)
In-Reply-To: <20110605182256.GG11521@ZenIV.linux.org.uk>
Thanks, Al
On 06/05/2011 01:22 PM, Al Viro wrote:
> Callers of lmLogOpen() expect it to return -E... on failure exits, which
> is what it returns, except for the case of blkdev_get_by_dev() failure.
> It that case lmLogOpen() return the error with the wrong sign...
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Dave Kleikamp <dave.kleikamp@oracle.com>
> ---
> diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
> index 278e3fb..583636f 100644
> --- a/fs/jfs/jfs_logmgr.c
> +++ b/fs/jfs/jfs_logmgr.c
> @@ -1123,7 +1123,7 @@ int lmLogOpen(struct super_block *sb)
> bdev = blkdev_get_by_dev(sbi->logdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL,
> log);
> if (IS_ERR(bdev)) {
> - rc = -PTR_ERR(bdev);
> + rc = PTR_ERR(bdev);
> goto free;
> }
>
prev parent reply other threads:[~2011-06-06 13:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 18:22 [PATCH] lmLogOpen() broken failure exit Al Viro
2011-06-06 13:42 ` Dave Kleikamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DECD934.6000004@oracle.com \
--to=dave.kleikamp@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.